search

CodelyTV / dotly

🌚 Modular and easy to customize dotfiles framework
https://codely.com/cursos
MIT License
1.19k stars 116 forks source link

Full installation of Xcode is required #89

Open JavierCane opened 3 years ago

JavierCane commented 3 years ago

As per #69, we would be automatically installing the Command Line Tools in order to have git available during dotly install:

https://github.com/CodelyTV/dotly/blob/4828b1468f826c305a2696bb7ef032b1cd51e927/installer#L98-L113

However, it seems that we would need an entire installation of Xcode in order to run mas:

%  bash <(curl -s https://raw.githubusercontent.com/CodelyTV/dotly/master/installer)
  ┌────────────────────────────────────┐
~ │ 🚀 Welcome to the dotly installer! │ ~
  └────────────────────────────────────┘

🤔 Where do you want your dotfiles to be located? (default ~/.dotfiles): 
 > Initializing your dotfiles git repository
 > Cloning dotly
 > Installing dotly dependencies
 > 🍎 Setting up macOS platform
 > Installing needed gnu packages
Error: No such keg: /opt/homebrew/Cellar/bash
Error: No such keg: /opt/homebrew/Cellar/zsh
Error: No such keg: /opt/homebrew/Cellar/coreutils
Error: No such keg: /opt/homebrew/Cellar/make
Error: No such keg: /opt/homebrew/Cellar/gnu-sed
Error: No such keg: /opt/homebrew/Cellar/findutils
Error: No such keg: /opt/homebrew/Cellar/bat
Error: No such keg: /opt/homebrew/Cellar/hyperfine
 > Installing mas
Error: No such keg: /opt/homebrew/Cellar/mas
mas: A full installation of Xcode.app 10.2 is required to compile
this software. Installing just the Command Line Tools is not sufficient.

Xcode can be installed from the App Store.
Error: An unsatisfied requirement failed this build.

It seems that we would not be able to automate the installation of Xcode. You have to manually install it through the App Store, or downloading it from the Apple Developer website after signing in with your Developer ID.

Would you find useful if even if having to do this by hand, we handle this error and instruct the user on how to proceed?

rgomezcasas commented 3 years ago

I've been there… Once you install the Xcode (1h process) you'll be able to install mas, but not to execute it, since they have a bug

The only way to run mas is using rosetta. We could download a new release and install it manually.

For now, I'll disable the mas installation on apple silicon devices.

What do you think?

JavierCane commented 3 years ago

Good one. Thanks!

It seems they also have this PR waiting for some modifications due to the Homebrew 3 upgrade ☺️

Would you find OK if I rename this issue to something like "Add mas support for Apple Silicon (arm64)" and keep it open until we can actually solve it?