search

ColeDeanShepherd / TESUnity

World viewers for Elder Scrolls games in the Unity game engine.
MIT License
92 stars 19 forks source link

Framerate Drop When Looking at Doors #20

Closed Sinuousity closed 8 years ago

Sinuousity commented 8 years ago

Issue is due to unnecessary rebuilding and setting of the active state of the interactTextObj Text mesh. Also impacted by using GetComponent() to find the Text component every frame.

Will be fixed by caching a reference to the Text component on interactTextObj and only activating or deactivating interactTextObj when necessary.

Sinuousity commented 8 years ago

Fixed on my fork.

ColeDeanShepherd commented 8 years ago

Thanks Sinuousity, feel free to make a pull request if you'd like. If not, I'll check out your fork later and incorporate the changes.

Sinuousity commented 8 years ago

I'm still new to GitHub / Repositories, so forgive me if I do things a little incorrectly or just don't know what to do. I'll put in the pull request, though.

ColeDeanShepherd commented 8 years ago

I've merged your pull request. Thanks again for all your great work! By the way, I added support for big endian CPUs in a commit last night, you should incorporate it into your fork!