search

ColeDeanShepherd / TESUnity

World viewers for Elder Scrolls games in the Unity game engine.
MIT License
92 stars 19 forks source link

Added an underwater effect #33

Closed demonixis closed 8 years ago

demonixis commented 8 years ago

Hi,

This PR adds an underwater effect. I had to change the water prefab because it has only one side so I added a new reversed side as a children of the original prefab. The reversed side uses a standard material with just one transparent color. It's not the best solution, but it's OK for now.

This fixes the issue #13

ColeDeanShepherd commented 8 years ago

Nice! Unfortunately I don't have time to resolve the merge conflicts right now, I'll try to get this branch merged in later today.

demonixis commented 8 years ago

Hi, I have updated the branch, it must be fine now.

I have noted that the virtual reality checkbox is unchecked at each merge on this repository. What version of Unity do you use? I have switched to the stable version for the good of the project ;)

ColeDeanShepherd commented 8 years ago

Hmm, that's strange... I'll look into it.

I'm using Unity 5.1.4.1f1. I think the VS project files are still in the repository even though you added them to .gitignore, maybe that has something to do with it? I need to stop tracking those files.

demonixis commented 8 years ago

Hum... That's caused by your Unity version. Can you update to the current release?

demonixis commented 8 years ago

Hum... That's caused by your Unity version. Can you update to the current release?

ColeDeanShepherd commented 8 years ago

I haven't changed anything in your pull requests though, so I don't think that my Unity version is affecting it. One of your pull requests updated the Unity version in TESUnity's settings as well...

With that said, though, I'm going to update to 5.4.1p4 (it was just released yesterday) and upgrade the project.

ColeDeanShepherd commented 8 years ago

I updated my version of Unity and upgraded the project. I also found out that develop was a few commits behind master. Now everything is up to date, maybe that will fix the problem.

demonixis commented 8 years ago

Yes that's the Unity version. In fact Unity 5.4 introduced the OpenVR support (HTC Vive) and a new system to enable VR support in Unity projects. With Unity 5.4+ all will be fixed ;)