search

ColeDeanShepherd / TESUnity

World viewers for Elder Scrolls games in the Unity game engine.
MIT License
92 stars 19 forks source link

Merge demonixis's updates. #45

Closed ColeDeanShepherd closed 6 years ago

demonixis commented 6 years ago

Hi!

Glad you liked my work, I've not submitted a pull request by myself because I wanted to tweak the scene with your default settings before that. Also I would like to talk with you about my changes to see if it's compatible with what you want to the project.

As you now, my fork is mainly focused on VR and graphics. Let me now if you want to change few things, I can adapt my work.

However, Unity 2018.1 is required for this code because it use the new package manager, which is very cool because we don't have to upload some plugins. If you want to talk more about Unity 2018, Don't hesitate to contact me by email, it's a nice subject ;)

ColeDeanShepherd commented 6 years ago

Hey demonixis, you're doing great work, but I understand that not all of the changes in your fork are applicable to mine. No worries, you don't have to worry about adapting your work unless you want to! Maybe I will take a closer look at your changes myself and see if I can extract certain improvements, like automatic normal map generation, and apply them to my repo.

demonixis commented 6 years ago

Don't worry all my changes can be merged! It's made to work in VR And without like your repo. My point is my current XR branch is not yet ready to be merged in yours because I've few extras debug things in it. But it's definitely planned. Let me now when you're ready to switch to Unity 2018.1 and I'll prepare a nice PR 😀