ColinIanKing / fwts

NOT THE UPSTEAM FWTS REPO, see https://github.com/fwts/fwts instead!
https://wiki.ubuntu.com/Kernel/Reference/fwts
28 stars 11 forks source link

Need to add additional start method value for ACPI table for TPM 2.0 #14

Open I-am-UE opened 11 months ago

I-am-UE commented 11 months ago

Source file: src/acpi/tpm2/tpm2.c - tpm2_test1() routine

Spec: TCG ACPI Specification Family for TPM 1.2 and 2.0 Version 1.3 Revision 8

0 Not allowed (indicates value has not been set). 1 Reserved for legacy use (vendor specific). 2 Uses the ACPI Start method. 3 – 5 Reserved for legacy use (vendor specific). 6 Reserved for the Memory mapped I/O Interface (TIS 1.2+Cancel). 7 Uses the Command Response Buffer Interface. 8 Uses the Command Response Buffer Interface with the ACPI Start Method. 9 – 10 Reserved for legacy use (vendor specific). 11 Uses the Command Response Buffer Interface with Arm Secure Monitor or Hypervisor Call (SMC/HVC) 12 Uses the FIFO Interface over I2C bus. 13 Reserved for future Memory mapped I/O Interface 14 Reserved for future Memory mapped I/O Interface. 15+ Reserved for future use

superm1 commented 8 months ago

FYI - this is the wrong repo for upstream FWTS. You should be using https://github.com/fwts/fwts

In any case - this is fixed in the latest code, just not yet into a FWTS release yet. https://github.com/fwts/fwts/commit/ded5290bd6cece44b7b0a61aa04738915927e3a4