search

ColinIanKing / fwts

NOT THE UPSTEAM FWTS REPO, see https://github.com/fwts/fwts instead!
https://wiki.ubuntu.com/Kernel/Reference/fwts
28 stars 11 forks source link

Out-of-tree builds fail #2

Closed rossburton closed 3 years ago

rossburton commented 3 years ago 
make[3]: Entering directory '/yocto/ross/build/tmp/work/neoversen1-poky-linux/fwts/20.07.00-r0/build/src/libfwtsiasl'
m4 -P -I../acpica/source/compiler ../acpica/source/compiler/aslparser.y > ../../../fwts-20.07.00/src/libfwtsiasl/aslcompiler.y
m4: cannot open `../acpica/source/compiler/aslparser.y': No such file or directory
ColinIanKing commented 3 years ago

check you are building it correctly:

autoreconf -ivf
./configure
make clean
make

If this fails, please supply the details of your build system (kernel, compiler version and architecture).

rossburton commented 3 years ago

I'm building it correctly, with an out-of-tree build.

cd fwts
mkdir build
../configure
make

This fails because the src/libfwtsiasl Makefile is writing generated files to $srcdir and trying to read source files from the build directory.

ColinIanKing commented 3 years ago

OK - I can reproduce this now, we've never done out-of-tree-builds so the relative path'ing is a bit broken. I'll sort that out

ColinIanKing commented 3 years ago

Fix sent for review at fwts-devel mailing list:

https://lists.ubuntu.com/archives/fwts-devel/2021-April/012925.html

rossburton commented 3 years ago

Bits like this concern me:

+kernelscan_SOURCES = kernelscan.c $(srcdir)/../lib/src/fwts_json.c

Is fwts_json.c generated? If so, it should be written into builddir not srcdir.

ColinIanKing commented 3 years ago

It's not generated, it's part of the fwts source

ColinIanKing commented 3 years ago

Fix released.