ComPWA / ComPWA-legacy

[deprecated] C++ back-end for the Common Partial Wave Analysis framework

https://compwa.github.io/legacy

Other

9 stars 9 forks source link

Geneva fix #223

Closed spflueger closed 5 years ago

spflueger commented 5 years ago

Fixed Geneva interface module

Closes #221
Geneva interface code now compiles.
Geneva test are working (find correct minima). However the performance is extremely poor. Not sure what causes this.
Adapted GenevaResult. However error estimates, covariance matrix and further properties are missing.
The user can now specify an order of algorithms in the GenevaIF. These algorithms will be used in the minimization in exactly this order.

spflueger commented 5 years ago

The Estimator pointer in GFMinIndividual.hpp is not nice, but I'm not sure how we can Interface Geneva otherwise... Let me know what you think

codecov[bot] commented 5 years ago

Codecov Report

Merging #223 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #223   +/-   ##
=======================================
  Coverage   46.56%   46.56%           
=======================================
  Files          97       97           
  Lines        5742     5742           
=======================================
  Hits         2674     2674           
  Misses       3068     3068