search

ComPWA / ComPWA-legacy

[deprecated] C++ back-end for the Common Partial Wave Analysis framework
https://compwa.github.io/legacy
Other
9 stars 9 forks source link

Dalitz analysis fit fraction #253

Closed weidenka closed 4 years ago

weidenka commented 4 years ago

Extends PR #238. There is still an issue with the fit. The phi(1020) magnitude is not fitted properly. I'm not sure if that has to do with the changes to the IntensityBuilderXML.

spflueger commented 4 years ago

Ok, I will have to take a look tomorrow.

The phi(1020) magnitude is not fitted properly.

What does this mean? The value is just not within the errors?

Btw, I was not aware that any of you are using this pull request for development. So I rebased it again... So your commits probably don't match mine and you would have to fix that.

weidenka commented 4 years ago

Problems with the fit parameters were related to a mistake in the model file.

spflueger commented 4 years ago

Problems with the fit parameters were related to a mistake in the model file.

Ok good

weidenka commented 4 years ago

There is still an issue with updating the intensity from a fit result. Since ComPWA::initializeWithFitResult() tries to set also values of fixed parameters an expection is thrown.