ComPWA / ComPWA-legacy

[deprecated] C++ back-end for the Common Partial Wave Analysis framework
https://compwa.github.io/legacy
Other
9 stars 9 forks source link

Improve header of the ASCII reader and make compatible with Pawian #280

Closed redeboer closed 4 years ago

redeboer commented 4 years ago

The current Ascii::readData function can read Pawian-like momentum tuple files with and without a 'header' (see Doxygen comments for illustration of the format). However, there are a few issues with this:

To make matters more complicated, there is interest to have this header parser implemented in Pawian as well. Since the aim of this reader is to make comparison between the two frameworks more easy, decisions on this issue should be fine-tuned to each other.

redeboer commented 4 years ago

Note: there was an idea to allow the user to tell the Ascii::readData function how to interpret the data file by feeding it a Kinematics object (which contains the final state particles). Considering the remarks above, it's probably better to abandon that idea and to expect the user to supply a header in the data file.

spflueger commented 4 years ago

Yeah the header solution is better. Are there any news on this?

redeboer commented 4 years ago

Fixed by https://github.com/ComPWA/ComPWA/pull/304