search

ComPWA / ComPWA-legacy

[deprecated] C++ back-end for the Common Partial Wave Analysis framework
https://compwa.github.io/legacy
Other
9 stars 9 forks source link

Eventlist refactor #306

Closed redeboer closed 4 years ago

redeboer commented 4 years ago

In the Event class, Particle has been replaced by FourMomentum. The particle information is contained within a list of PIDs that is contained within the EventList class. This required a lot of refactoring, but allows for checking the PIDs when for instance doing kinematic variable conversion.

Note that the format of RootDataIO has been changed as well: no use is made of the infamous TClonesArray anymore (note that even ROOT writes "It is recommended to use STL containers instead of TClonesArrays").

I also took the liberty to rename several variables to make them agree with our naming conventions.

codecov[bot] commented 4 years ago

Codecov Report

Merging #306 into master will increase coverage by 1.35%. The diff coverage is 72.47%.

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
+ Coverage   36.68%   38.03%   +1.35%     
==========================================
  Files          88       84       -4     
  Lines        7373     7274      -99     
==========================================
+ Hits         2705     2767      +62     
+ Misses       4668     4507     -161
redeboer commented 4 years ago

The design of EventCollection could definitely be made safer (either making Events and Pids const or by making them private). I tried but then ran into several problems where (1) STL algorithms need direct access to the Events vector and (2) the EventCollection is build up in steps using for instance push_back.