ComPWA / ComPWA-legacy

[deprecated] C++ back-end for the Common Partial Wave Analysis framework

https://compwa.github.io/legacy

Other

9 stars 9 forks source link

build!: split ROOT and Minuit dependency #314

Closed redeboer closed 8 months ago

redeboer commented 4 years ago

Closes https://github.com/ComPWA/ComPWA/issues/272

codecov[bot] commented 4 years ago

Codecov Report

Merging #314 into master will decrease coverage by 1.55%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
- Coverage   38.57%   37.01%   -1.56%     
==========================================
  Files          86       86              
  Lines        7365     7661     +296     
==========================================
- Hits         2841     2836       -5     
- Misses       4524     4825     +301

redeboer commented 4 years ago

This is WIP: Travis doesn't work yet (locally it does) and may have to split this PR up, because it's currently horror to review. See https://github.com/ComPWA/ComPWA/pull/314/commits

[ ] Extract addition of developer tools (72f439c165845b50f2bd3d46ee635be2694efd02)
[ ] Separate formatting commits of CMakeLists.txt files
[ ] Separate out improvements to the Travis CI
[ ] Separate out removal of include_directories

spflueger commented 4 years ago

Why are there some many formatting changes for other source and header files? Where they not formatted correctly?

redeboer commented 4 years ago

Why are there some many formatting changes for other source and header files? Where they not formatted correctly?

Because of the removal of include_directories in the main CMakeLists.txt. I work with target_include_directories now so that the files are more standalone, but it requires changing #include statements.

C++ source code in the ThirdParty directory hadn't been formatted so far, that's probably why they were now.