search

ComfyWorkflows / ComfyUI-Launcher

Run any ComfyUI workflow w/ ZERO setup.
GNU Affero General Public License v3.0
541 stars 61 forks source link

Remove dist folder #15

Closed TheKnarf closed 7 months ago

TheKnarf commented 7 months ago
thecooltechguy commented 7 months ago

hi @TheKnarf , atm the launcher is comprised of a Python Flask server that serves a React front-end app.

Because we don't want users to need npm/node to build the React app on their end, we currently keep the built js/html/css files in the repo, so that all the user needs to do is start the Flask server and they'll be able to instantly access the React web app.

Storing dist/ in the repo is not ideal, but in this case, it helps simplify the setup & usage for the end user, so if we were to just remove it rn, the app would not install properly for users.

Hmm, is there perhaps another way to achieve this same goal, without needing to add/track the dist/ folder in the repo and requiring the user to have npm/node on their end?

TheKnarf commented 7 months ago

Couldn't you just require node and run npm build inside of run.sh? This seems like a really weird way of solving it...