ComfyWorkflows / ComfyUI-Launcher

Run any ComfyUI workflow w/ ZERO setup.
GNU Affero General Public License v3.0
441 stars 50 forks source link

Bug cloning repo on import workflow #32

Open jordibass opened 3 months ago

jordibass commented 3 months ago

as per my log:

[2024-04-10 10:35:09,266: WARNING/ForkPoolWorker-1] Cloning into '/Users/jordi/Comfy_Projects/ipa-comp-style/comfyui/custom_nodes/SDXLAspectRatio.py'...
[2024-04-10 10:35:09,515: WARNING/ForkPoolWorker-1] remote: 404: Not Found
[2024-04-10 10:35:09,517: WARNING/ForkPoolWorker-1] fatal: repository 'https://raw.githubusercontent.com/throttlekitty/SDXLCustomAspectRatio/main/SDXLAspectRatio.py/' not found
[2024-04-10 10:35:09,933: DEBUG/MainProcess] Timer wake-up! Next ETA 1.0 secs.
[2024-04-10 10:35:10,934: DEBUG/MainProcess] Timer wake-up! Next ETA 0.9986971669999889 secs.
127.0.0.1 - - [10/Apr/2024 10:35:11] "GET /api/projects HTTP/1.1" 200 -
[2024-04-10 10:35:11,938: DEBUG/MainProcess] Timer wake-up! Next ETA 1.0 secs.
[2024-04-10 10:35:12,943: DEBUG/MainProcess] Timer wake-up! Next ETA 0.9948857089999876 secs.
[2024-04-10 10:35:13,940: DEBUG/MainProcess] Timer wake-up! Next ETA 1.0 secs.
[2024-04-10 10:35:14,945: DEBUG/MainProcess] Timer wake-up! Next ETA 0.9948670000000277 secs.
[2024-04-10 10:35:15,945: DEBUG/MainProcess] Timer wake-up! Next ETA 1.0 secs.
[2024-04-10 10:35:16,950: DEBUG/MainProcess] Timer wake-up! Next ETA 0.9948556250000138 secs.
[2024-04-10 10:35:17,946: DEBUG/MainProcess] Timer wake-up! Next ETA 1.0 secs.
[2024-04-10 10:35:18,948: DEBUG/MainProcess] Timer wake-up! Next ETA 0.9982914169999901 secs.
[2024-04-10 10:35:19,952: DEBUG/MainProcess] Timer wake-up! Next ETA 1.0 secs.
[2024-04-10 10:35:20,070: ERROR/ForkPoolWorker-1] Task tasks.create_comfyui_project[56a40d8f-4bab-4973-b1fb-4e03c2304400] raised unexpected: AssertionError()
Traceback (most recent call last):
  File "/Users/jordi/comfyui-launcher/venv/lib/python3.9/site-packages/celery/app/trace.py", line 477, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/Users/jordi/comfyui-launcher/server/server.py", line 36, in __call__
    return self.run(*args, **kwargs)
  File "/Users/jordi/comfyui-launcher/server/tasks.py", line 89, in create_comfyui_project
    setup_custom_nodes_from_snapshot(project_folder_path, launcher_json)
  File "/Users/jordi/comfyui-launcher/server/utils.py", line 220, in setup_custom_nodes_from_snapshot
    run_command(["git", "clone", custom_node_repo_url, custom_node_path, "--recursive"])
  File "/Users/jordi/comfyui-launcher/server/utils.py", line 112, in run_command
    assert process.wait() == 0
AssertionError
[2024-04-10 10:35:20,954: DEBUG/MainProcess] Timer wake-up! Next ETA 0.9975047500000187 secs.
127.0.0.1 - - [10/Apr/2024 10:35:21] "GET /api/projects HTTP/1.1" 200 -

the main problem it tries to clone 'https://raw.githubusercontent.com/throttlekitty/SDXLCustomAspectRatio/main/SDXLAspectRatio.py/' with the / at the end causing an exception.

the workflow I try to import IPA Comp+Style.json

HASAN3DG commented 3 months ago

same +1

https://drive.google.com/file/d/1hth5KX9V6Le7jl3s4_bGNu8giFd3Uzyn/view?usp=sharing

abess96 commented 3 months ago

I am also facing this issue