Closed CRCODE22 closed 4 months ago
hey @CRCODE22! sorry about that, can you please share the following info?
also, when you navigate to localhost:4000 does everything work fine?
by the way, just found this thread that might help: https://support.mozilla.org/en-US/questions/1276189 - this might just be a firefox issue.
what folder do you install from?
what folder do you install from?
hi @CalmClarity! do you mean for the manual setup or for docker? there's no "folder" that has an executable that you can install, you just need to clone this repository or execute the docker run command in your terminal (in whatever directory) as described in the README.
for manual setup you can clone this repo in whatever folder you want, and then you cd/ into the folder you just populated and add the ./run.sh command using chmod as shown in the README. for docker (only available on windows WSL and linux, not mac yet) you can go into any directory as well and run this command:
docker run \
--gpus all \
--rm \
--name comfyui_launcher \
--net=host \
-v $(pwd)/comfyui_launcher_models:/app/server/models \
-v $(pwd)/comfyui_launcher_projects:/app/server/projects \
-it thecooltechguy/comfyui_launcher
this will start the server and give you a localhost link to navigate to from your browser.
i'm afraid i'm not sure what you're asking though, do you mean where to install the launcher or where to install custom_nodes/models, etc.?
by the way if you mean where to install models then you could do that through the manager or by adding files manually into your /comfyui-launcher/server/projects/
@CRCODE22 + @CalmClarity if you guys have been using windows and the launcher hasn't been working for you please try following the instructions in this new branch we're testing for windows installation support: https://github.com/ComfyWorkflows/ComfyUI-Launcher/tree/new-docker-setup
Hi
Thank you for extra information, will try again, with wsl.
As im working on native windows. Im hoping it will get all the nodes installed correct for some of the work flows people are sharing, they can get quite complicated.
Kind regards,
From: dylan @.> Sent: Friday, March 8, 2024 7:43:09 PM To: ComfyWorkflows/ComfyUI-Launcher @.> Cc: CalmClarity @.>; Mention @.> Subject: Re: [ComfyWorkflows/ComfyUI-Launcher] The docker image cannot be reached through the browser. (Issue #8)
@CRCODE22https://github.com/CRCODE22 + @CalmClarityhttps://github.com/CalmClarity if you guys have been using windows and the launcher hasn't been working for you please try following the instructions in this new branch we're testing for windows installation support: https://github.com/ComfyWorkflows/ComfyUI-Launcher/tree/new-docker-setup
— Reply to this email directly, view it on GitHubhttps://github.com/ComfyWorkflows/ComfyUI-Launcher/issues/8#issuecomment-1986308342, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWZSIO2NFS7SRULAAC6NWG3YXIIE3AVCNFSM6AAAAABEKYKSY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBWGMYDQMZUGI. You are receiving this because you were mentioned.Message ID: @.***>
Hi Thank you for extra information, will try again, with wsl. As im working on native windows. Im hoping it will get all the nodes installed correct for some of the work flows people are sharing, they can get quite complicated. Kind regards, … ____ From: dylan @.> Sent: Friday, March 8, 2024 7:43:09 PM To: ComfyWorkflows/ComfyUI-Launcher @.> Cc: CalmClarity @.>; Mention @.> Subject: Re: [ComfyWorkflows/ComfyUI-Launcher] The docker image cannot be reached through the browser. (Issue #8) @CRCODE22https://github.com/CRCODE22 + @CalmClarityhttps://github.com/CalmClarity if you guys have been using windows and the launcher hasn't been working for you please try following the instructions in this new branch we're testing for windows installation support: https://github.com/ComfyWorkflows/ComfyUI-Launcher/tree/new-docker-setup — Reply to this email directly, view it on GitHub<#8 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWZSIO2NFS7SRULAAC6NWG3YXIIE3AVCNFSM6AAAAABEKYKSY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBWGMYDQMZUGI. You are receiving this because you were mentioned.Message ID: @.***>
awesome, thanks @CalmClarity! when you test can you paste any errors you might get after clicking the "launch" button on a project you've imported/created please?
hey @CalmClarity + @CRCODE22 - new update! we just pushed a fix to the new-docker-setup branch. if you guys could follow the instructions (option 1: docker) on that branch's README, you should be able to get the launcher to work! thank you for your patience.
let me know if it works and if this issue should be closed!
essentially this is the only command that you would have to run (make sure docker is installed on your machine):
docker run \
--gpus all \
--rm \
--name comfyui_launcher \
-p 4000-4100:4000-4100 \
-v $(pwd)/comfyui_launcher_models:/app/server/models \
-v $(pwd)/comfyui_launcher_projects:/app/server/projects \
-it thecooltechguy/comfyui_launcher:new-docker-setup
okay got it to install, but when accessing http://localhost:4000 in web browser the connection is refused
calm@workstation:~$ docker run \
--gpus all \ --rm \ --name comfyui_launcher \ --net=host \ -v $(pwd)/comfyui_launcher_models:/app/server/models \ -v $(pwd)/comfyui_launcher_projects:/app/server/projects \ -it thecooltechguy/comfyui_launcher Unable to find image 'thecooltechguy/comfyui_launcher:latest' locally latest: Pulling from thecooltechguy/comfyui_launcher e1caac4eb9d2: Pull complete 51d1f07906b7: Pull complete c0d8da8ab021: Pull complete ce524da9d572: Pull complete d0d45da63dd1: Pull complete 0c0f7b089119: Pull complete b561f2eefa8f: Pull complete 03395d9b6222: Pull complete fedca84cc36b: Pull complete 8c5712b0aed4: Pull complete 2bcc43eeca69: Pull complete 128c61ebabf3: Pull complete 4f4fb700ef54: Pull complete Digest: sha256:f6394d7c7ebd49d67c70c9f867dcce22d0741b9518350cfe37ba6cc0397663f8 Status: Downloaded newer image for thecooltechguy/comfyui_launcher:latest Starting ComfyUI Launcher... Open http://localhost:4000 in your browser.
- Serving Flask app 'server'
- Debug mode: off
okay got it to install, but when accessing http://localhost:4000 in web browser the connection is refused
calm@workstation:~$ docker run \
--gpus all --rm --name comfyui_launcher --net=host -v $(pwd)/comfyui_launcher_models:/app/server/models -v $(pwd)/comfyui_launcher_projects:/app/server/projects -it thecooltechguy/comfyui_launcher Unable to find image 'thecooltechguy/comfyui_launcher:latest' locally latest: Pulling from thecooltechguy/comfyui_launcher e1caac4eb9d2: Pull complete 51d1f07906b7: Pull complete c0d8da8ab021: Pull complete ce524da9d572: Pull complete d0d45da63dd1: Pull complete 0c0f7b089119: Pull complete b561f2eefa8f: Pull complete 03395d9b6222: Pull complete fedca84cc36b: Pull complete 8c5712b0aed4: Pull complete 2bcc43eeca69: Pull complete 128c61ebabf3: Pull complete 4f4fb700ef54: Pull complete Digest: sha256:f6394d7c7ebd49d67c70c9f867dcce22d0741b9518350cfe37ba6cc0397663f8 Status: Downloaded newer image for thecooltechguy/comfyui_launcher:latest Starting ComfyUI Launcher... Open http://localhost:4000 in your browser.
- Serving Flask app 'server'
- Debug mode: off
ah yes it's because as I said in the previous message, the correct command to run is this one:
docker run \
--gpus all \
--rm \
--name comfyui_launcher \
-p 4000-4100:4000-4100 \
-v $(pwd)/comfyui_launcher_models:/app/server/models \
-v $(pwd)/comfyui_launcher_projects:/app/server/projects \
-it thecooltechguy/comfyui_launcher:new-docker-setup
you're running the wrong command - the one with --net=host
. let me know if this command works so that we can close this issue!
okay thank you, it works now, but I'm confused, it is downloading all the files to the docker container, how to i get these to install to my B: folder where i run comfy from? i might be missing the point, is this for people running comfy in linux? i just go to the b: run gpu and it loads i have been using the comfy node manger but things do not install properly so I'm trying your workflow installer. Should i open a different request because it is clearly working now i just don't know what doing with it
am i able copy them from the docker container folder before i close it, i says that the information will disappear
hi @CalmClarity
all of your comfyui projects + model files are saved to disk, so you won't lose any data.
In the following docker commands from our README (https://github.com/ComfyWorkflows/comfyui-launcher?tab=readme-ov-file#option-1-docker-linux--windows):
Linux
docker run \
--gpus all \ # remove this line if you don't have a GPU or if you're on MacOS
--rm \
--name comfyui_launcher \
-p 4000-4100:4000-4100 \
-v $(pwd)/comfyui_launcher_models:/app/server/models \
-v $(pwd)/comfyui_launcher_projects:/app/server/projects \
-it thecooltechguy/comfyui_launcher
Windows
docker run ^
--gpus all ^ # remove this line if you don't have a GPU
--rm ^
--name comfyui_launcher ^
-p 4000-4100:4000-4100 ^
-v %cd%/comfyui_launcher_models:/app/server/models ^
-v %cd%/comfyui_launcher_projects:/app/server/projects ^
-it thecooltechguy/comfyui_launcher
notice that the -v
options in the commands will make Docker create 2 folders in your current directory (relative to where you run this command), where all the model files and comfyui workflow project files will be stored on your computer.
this ensures that, the next time you run the same docker command from the same working directory, you should have all of your workflows and model files remain, and not get deleted.
lmk if you have any questions! :)
Closing due to no response, feel free to re-open anytime!
Unable to connect
An error occurred during a connection to thelocalipofmycomputer:4000
The site could be temporarily unavailable or too busy. Try again in a few moments. If you are unable to load any pages, check your computer’s network connection. If your computer or network is protected by a firewall or proxy, make sure that Firefox is permitted to access the web.
2024-03-07 11:48:15 WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead. 2024-03-07 11:48:15 Running on all addresses (0.0.0.0) 2024-03-07 11:48:15 Running on http://127.0.0.1:4000 2024-03-07 11:48:15 * Running on http://***.**.*.*:4000 2024-03-07 11:48:15 Press CTRL+C to quit 2024-03-07 11:48:15 Starting ComfyUI Launcher... 2024-03-07 11:48:15 Open http://localhost:4000 in your browser. 2024-03-07 11:48:15 Serving Flask app 'server' 2024-03-07 11:48:15 Debug mode: off