time is a struct and omitempty won't work. making it a ptr solves this

ComplianceCow / CAML

Continuous Audit Metrics Catalog

Other

4 stars 6 forks source link

time is a struct and omitempty won't work. making it a ptr solves this #2

Closed pritikin closed 2 years ago

pritikin commented 2 years ago

I'm not sure what it would mean if times are not specified. Perhaps that the measure is being taken w/in a time period such as the default specified in the metric catalog w/o explicitly indicating the start/end date?

An alternative is that we mandate the period be filled in and therefore drop "omitempty" from the struct's JSON tag?

rajkrishnamurthy commented 2 years ago

Hi Max: I have already incorporated the change. Plus, I have totally changed the naming convention. Please rebase.