search

ComputationalBiomechanicsLab / opensim-creator

A UI for building OpenSim models
https://opensimcreator.com
Apache License 2.0
141 stars 17 forks source link

Upstream downgrade some of OpenSim's `abort`ing assertions to exceptions instead #730

Closed adamkewley closed 1 year ago

adamkewley commented 1 year ago

E.g. OpenSim contains assertions for ligament length (nonzero) that, when trying to debug an OSC build, will entirely abort the application, rather than it being reported via an exception.

Both are halting errors, but the benefit of an exception is that I can at least run "does this code cause a segafult" type tests in downstream code without the test suite being nuked by a stray abort in OpenSim.

[ RUN      ] ForceRegistry.CanAddAnyForceWithoutASegfault
testopensimcreator: /home/adam/opensim-creator/third_party/opensim-core/OpenSim/Simulation/Model/Ligament.cpp:85: virtual void OpenSim::Ligament::extendFinalizeFromProperties(): Assertion `get_resting_length() > 0.0' failed.
Aborted
adamkewley commented 1 year ago

This is now upstreamed and will be handled separately.