Fix (upstream) segfault when trying to delete random joints from model - Githubissues

ComputationalBiomechanicsLab / opensim-creator

A UI for building OpenSim models

https://opensimcreator.com

Apache License 2.0

141 stars 17 forks source link

Fix (upstream) segfault when trying to delete random joints from model #751

Open adamkewley opened 1 year ago

adamkewley commented 1 year ago

Repro:

Remove the commented-out "don't even try to delete a joint" code block:

// disable deleting joints: it's super-easy to segfault because of some unknown
// fuckery happening in OpenSim::Model::createMultibodySystem
// if (auto* js = dynamic_cast<OpenSim::JointSet*>(owner))
// {
//    rv = TryDeleteItemFromSet(*js, dynamic_cast<OpenSim::Joint*>(&c));
//}

Run the test suite
It'll segfault

It would be useful to create a minimal repro of this bug so that it can be put into an isolated test and upstreamed to opensim-core

adamkewley commented 1 month ago

Update: still broken (just tested it)