ComputationalBiomechanicsLab / opensim-creator

A UI for building OpenSim models
https://opensimcreator.com
Apache License 2.0
137 stars 16 forks source link

Fix crash when duplicating a live muscle plot #830

Closed adamkewley closed 3 months ago

adamkewley commented 3 months ago

Happened during a presentation, unsure of exact repro steps but roughly:

adamkewley commented 3 months ago

This was fixed but not tagged in a commit: the bug was (iirc) that the plot duplication routine was adding a panel to the PanelManager, which was holding onto Panels in a std::vector, which reallocated due to the addition, which invalidated a pointer further up the UI stack (e.g. it->onDraw()) etc. etc. - mmmmm native development