search

ComputerScienceHouse / bingehack4

A replacement for bingehack. For information about in-game features and changes:
https://github.com/ComputerScienceHouse/bingehack4/wiki
Other
17 stars 8 forks source link

Implemented dump_print_message. Fixes #9 #35

Closed mansam closed 11 years ago

mansam commented 11 years ago

This bug was occurring because going into dump mode did not replace the curses version of print_message when it replaced the other related windowport methods, so stuff intended for the dumpfile was winding up in the status line. I've fixed that by implementing dump_print_message, dump_print_message_core, and dump_print_message_nonblocking, which simply write the line out to the dumpfile.

clockfort commented 11 years ago

You should fix up a couple of the compiler errors. https://travis-ci.org/ComputerScienceHouse/bingehack4/jobs/4630800

It would be also ideal if you merged your soon-to-be fixes into a single commit (git rebase -i HEAD~2 and mark your fix commit as fixup) to not make a mess of our upstream branch. If not, I can do it for you.

mansam commented 11 years ago

Fixed the compiler warnings, but I think I fucked up the rebase.

clockfort commented 11 years ago

It's cool, I can do that for you. Testing now.

clockfort commented 11 years ago

Merged as 1f6fc3ab48290655dc59951e71a2ab69a44138f3 .

Thanks for your work Sam, sorry for making you jump through hoops :-)