search

CosmWasm / wasmd

Basic cosmos-sdk app with web assembly smart contracts
Other
359 stars 381 forks source link

Add `newWasmModuleEvent` test cases for empty values #1899

Closed chipshort closed 3 weeks ago

chipshort commented 4 weeks ago

This behaviour was originally changed in #1618, but tests were only added for newCustomEvents (used for Response.Events.Attributes), not for newWasmModuleEvent (used for Response.Attributes).

This came up while fixing the behaviour in MultiTest: https://github.com/CosmWasm/cw-multi-test/issues/178

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.88%. Comparing base (21b048d) to head (0b873c2).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/CosmWasm/wasmd/pull/1899/graphs/tree.svg?width=650&height=150&src=pr&token=rxXgFH3QTf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CosmWasm)](https://app.codecov.io/gh/CosmWasm/wasmd/pull/1899?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CosmWasm) ```diff @@ Coverage Diff @@ ## main #1899 +/- ## ========================================== + Coverage 54.86% 54.88% +0.02% ========================================== Files 65 65 Lines 9772 9772 ========================================== + Hits 5361 5363 +2 + Misses 3866 3865 -1 + Partials 545 544 -1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/CosmWasm/wasmd/pull/1899/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CosmWasm)