Open aadi58002 opened 1 year ago
I guess ideally both, but it may be the last screens don't work well on vertical, in which case it would be OK if the message which currently warns about general problems on mobile, instead tells the user to rotate to horizontal if on a tablet. Desktop browser windows may also have closer to vertical shape though.
Which page do you mean by last page ?
Also there are some pages (mainly obstacle,mass) which do not work well in vertical mode i tried to make them work but it was barely working and broke easily so i can add a popup saying to change to landscape on those pages. Aside from those two. I think other can be made for both vertical and horizontal . Are you ok with that ?
( Also i haven't seen all the pages so there might still be some pages which can't work with vertical )
Sounds ok. The last step is the actual game (the main thing, the rest is just into to explain it)
From: Aditya Yadav @.> Sent: Saturday, July 22, 2023 12:45:59 PM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
Which page do you mean by last page ?
Also there are some pages which are using ( mainly obstacle,mass) which do not work well in vertical mode i tried to make them work but it was barely working and broke easily so i can add a popup saying to change to landscape on those pages. Aside from those two. I think other can be made for both vertical and horizontal . Are you ok with that ?
( Also i haven't seen all the pages so there might still be some pages which can't work with vertical )
— Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1646564720, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI6OYAP5CNSTFJREEELXRO4PPANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
I am fixed the major things which i could see. https://github.com/aadi58002/huntfordm
Can you run the fork and tell me the things which you still want changes or some test which i might have missed ?
Can you set up a test site? I’m travelling..
From: Aditya Yadav @.> Sent: Saturday, July 22, 2023 3:21:56 PM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
I am fixed the major things which i could see. https://github.com/aadi58002/huntfordm
Can you run the fork and tell me the things which you still want changes or some test which i might have missed ?
— Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1646594761, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI46SAXBHQ4HKYI5ISLXRPOYJANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
It is night time in my country do you mind if I do it tomorrow?
No rush
From: Aditya Yadav @.> Sent: Saturday, July 22, 2023 6:06:51 PM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
It is night time in my country do you mind if I do it tomorrow?
— Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1646617778, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI6RZQTUODZE33WIA6LXRP3BXANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
https://huntfordm.vercel.app/ deployed site
The “please open this app in landscape mode” message also pops up in vertical-shaped browser windows on desktop, and there seems to be no way of getting rid of the message e.g. after re-sizing the window to be full screen the message still shows. I would just put this warning at the start as the other mobile warning message, but make sure it disappears if the screen is rotated/resized. On the previous screens the next can also overlap the buttons in landscape shapes.
I would change “Please open this app full screen in landscape mode.. “ since even in landscape, if the user is split-screen the browser window itself may not be landscape.
From: Aditya Yadav @.> Sent: 23 July 2023 03:04 To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
https://huntfordm.vercel.app/ deployed site
— Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1646714483, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI63ZHDPMSUJ4X6F7QTXRR2A3ANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
I added the close button as well the message will disappear on resize
You didn't run prettier on the code so should i format all the file and commit them ?
Ideally don’t change the format if it will complicate the git diff, but if you’ve already re-indented don’t worry (can view diffs without whitespace).
From: Aditya Yadav @.> Sent: 23 July 2023 09:52 To: CosmoPars/ntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
You didn't run prettier on the code so should i format all the file and commit them ?
— Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1646772400, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQIYKBLS6ZY54HGYNNS3XRTJYLANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
I commit the format changes in another commit so that it won't make the commit which cause change to logic harder to read.
I was trying to apply for the upwork job post which you posted . But it seem you have closed it. Can you reopen it so that i can officially claim this job ?
Still travelling.,. is the live site updated? Did you manage to fix the touch issues ok? I thought the job was already assigned, but can check when properly back online possibly tomorrow
Sent from Outlook for iOShttps://aka.ms/o0ukef
From: Aditya Yadav @.> Sent: Sunday, July 23, 2023 2:19:50 PM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
I was trying to apply for the upwork job post which you posted . But it seem you have closed it. Can you reopen it so that i can officially claim this job ?
— Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1646826260, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQIYXDCYUYD6CDTABXGTXRUJGNANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
I fixed it should be live now
Thanks. Definitely better, but some things don’t seem to work with touch on the iPad, e.g. the first up down slider moves the page not the slider. Some text also wrapping oddly or overlapping. Change the mobile warning pop up on the first paper, e.g. so no longer shown on landscape tablets and/or ask to rotate to landscape as appropriate.
From: Aditya Yadav @.> Sent: Sunday, July 23, 2023 3:04:13 AM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
https://huntfordm.vercel.app/ deployed site
— Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1646714483, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI63ZHDPMSUJ4X6F7QTXRR2A3ANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
Touch only worked once for me on the first drag, then stopped working. And touch drag did not work on later screens. I also see the landscape pop up even though already viewing on an iPad landscape.
Sent from Outlook for iOShttps://aka.ms/o0ukef
From: Antony Lewis @.> Sent: Sunday, July 23, 2023 6:40:29 PM To: CosmoPars/huntfordm @.>; CosmoPars/huntfordm @.> Cc: Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
Thanks. Definitely better, but some things don’t seem to work with touch on the iPad, e.g. the first up down slider moves the page not the slider. Some text also wrapping oddly or overlapping. Change the mobile warning pop up on the first paper, e.g. so no longer shown on landscape tablets and/or ask to rotate to landscape as appropriate.
From: Aditya Yadav @.> Sent: Sunday, July 23, 2023 3:04:13 AM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
https://huntfordm.vercel.app/ deployed site
— Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1646714483, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI63ZHDPMSUJ4X6F7QTXRR2A3ANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
I fixed the modal div popup error. I was not able to reproduce the slider stuck error on any of the pages.
I tried to move all the slider and they worked fine. You might want to try refreshing the page once.
The page https://huntfordm.vercel.app/tutorial/darkmatter has weird word wrap, the next page https://huntfordm.vercel.app/tutorial/interactivelens has the dark matter blob that I can’t move by touch ( and the text overlaps the Next button, probably the font size needs to scale with the viewport up to some max?).
From: Aditya Yadav @.> Sent: Sunday, July 23, 2023 7:43:36 PM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
I fixed the modal div popup error. I was not able to reproduce the slider stuck error on any of the pages.
I tried to move all the slider and they worked fine. You might want to try refreshing the page once.
— Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1646902381, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI5AOVYGFV36U4KIPITXRVPERANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
On upwork you are listed as "hired"
On upwork you are listed as "hired"
I don't see any active jobs on my portal.
The page https://huntfordm.vercel.app/tutorial/darkmatter has weird word wrap, the next page https://huntfordm.vercel.app/tutorial/interactivelens has the dark matter blob that I can’t move by touch ( and the text overlaps the Next button, probably the font size needs to scale with the viewport up to some max?). … ____ From: Aditya Yadav @.> Sent: Sunday, July 23, 2023 7:43:36 PM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1) I fixed the modal div popup error. I was not able to reproduce the slider stuck error on any of the pages. I tried to move all the slider and they worked fine. You might want to try refreshing the page once. — Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI5AOVYGFV36U4KIPITXRVPERANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
I fixed the word wrap and the interactive lens.
You'll have to ask UpWork what's going on there. I see things like this on desktop still
and more.
On iPad I still get message at being about being optimized for desktop, and I can't close the Help modal popup because Close button not visible. Also the first up-down slider till mostly doesn't work by touch (moves the page instead). The object now moves OK.
"We've hidden some dark matter for you" slightly overlaps the image.
tutorial/ending, touching in the image grid to find the dark matter doesn't seem to work..
Please use the vercel link on which i am deploying to check for the updated site
(Please test things carefully yourself, the idea is not to use the employer as test service! Testing is usually 50% of the work)
You'll have to ask UpWork what's going on there. I see things like this on desktop still
and more.
Ok I will test on most thing I can today. Can you tell me the device you got these screenshots on ?
I have been using my browser to test on tablet mode for 1080px width in landscape and 810px in width in portrait mode.
Those screenshots were on desktop window (not full screen, not in emulator). You should be able to freely re-size the desktop window to see what it looks like for a plausible range of desktop and tablet-like sizes.
It was the vercel link
On iPad the slider here is also way off
From: Aditya Yadav @.> Sent: Monday, July 24, 2023 8:31:32 AM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
Please use the vercel link on which i am deploying to check for the updated site
— Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1647295027, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQIY2UVNAKH4T6FDMFM3XRYJEJANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
https://huntfordm-aadi58002.vercel.app/tutorial -> I check all pages on the sizes which i think are in ranges of Tablet.
I still see some things like this where font scaling seems wrong
I increases the range on which the changes take effect. It should make it so that text and images don't collide now
I am trying to approach upwork support today. Can you send me the picture of the upwork portal which shows that i am hired for the job you posted ?
@.***
@.***
I don't get what you mean here
Hmm , looks like github did something weird with the pic, trying again:
Something is off with vertical alignment now on most pages e.g.
Can you send me a pic where it specifically mentions my username or shows my profile picture. You may have hired someone else.
My upwork profile -> https://www.upwork.com/freelancers/~019e1ce9bbbf97b2c6
The profile is called “Nusair A.” is that not you? Did you post messages on github but not on upwork ,and before being accepted? I assumed you were him just with a different username on gitthub – the messages on github started just after I stopped communicating with him on upwork.
From: Aditya Yadav @.> Sent: 25 July 2023 02:21 To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
Can you send me a pic where i mentions my username or shows my profile picture. You may have hired someone else.
My upwork profile -> https://www.upwork.com/freelancers/~019e1ce9bbbf97b2c6
— Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1648791057, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI37ZJF7YRGBVJQJUPDXR4GP3ANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
I wanted to confirm if you are good with my code before I applied to you on upwork. my name are common across all my account. My name is Aditya Yadav and my username name is aadi58002
Let me check what the person hired is up to
Any update on the matter ?
They say they are working on it. For future you shouldn't start working on something before being accepted, this confusion has potentially wasted quite lot of both our time. (but if the other guy doesn't deliver by the end of the week, I can try to assign you instead)
You don't seem to be on the list of bids for the project? When can you complete it and what would be your bid?
As mentioned in the upwork request i have started added tablet support to the site. But here i am not sure if the support you mention is for the iPad vertical mode or horizontal mode ( landscape mode )
I currently added and tested home,star,direct,obstacle,mass,newdarkmatter,darkmatter,interactivelens,slrare pages on the https://github.com/aadi58002/huntfordm/commit/136d755337da9472b660f282fa9041d0d47d6090 commit
Can you clarify the target device dimensions? Also can you look at the commit and clarify if you want me to keep working on this or should i change any type of styling choices which i have made in code.