Open aadi58002 opened 1 year ago
The job status shows that the job is no longer available. Completion time can vary but it max it should be around 4-5 days at max Bid -> Same as you posted on the job 100$
Try this https://www.upwork.com/jobs/~01c81c68486d697917
Looks like you've done most of it already, so would be good to have most done today if possible ready for further testing by my collaborators.
Try this https://www.upwork.com/jobs/~01c81c68486d697917
Looks like you've done most of it already, so would be good to have most done today if possible ready for further testing by my collaborators.
I let you know when the site vertical spacing issues you mentions are resolved
I made the changes can you see if you like any more changes ?
On the front page the help button position, and the help button popup alignment is wrong.
And this
And this. You really need to test things more carefully yourself.
I adjusted the font so that it smaller if there is not enough height to the screen.
There still seems to be some overlap here:
The "This what we see" box also tends to hind the thing it is talkign about
Ok I changed the resize changes limits to be bigger.
Are you confident that if I try this on my iPad I will not find any more obvious issues? If not, then you should test more yourself.
At the moment the first screen still gives the warning about being optimized for desktop. And the Help pop-up on the next screen still does not work correctly as mentioned previously (cannot close it).
Are you confident that if I try this on my iPad I will not find any more obvious issues? If not, then you should test more yourself.
At the moment the first screen still gives the warning about being optimized for desktop. And the Help pop-up on the next screen still does not work correctly as mentioned previously (cannot close it).
I fixed the warning message on the first page. As for the pop up on the rest of the pages
There should be the red cross mark on top right.
By help popup I meant the "?" help button.
It should be fixed now.I checked the help button on both landscape and portrait mode.
What did you change? on iPad landscape the still doesn't fit my screen and close button is not visible (and it does not scroll)
On /interactivelens, touch dragging the mass and slider also doesn't work (or is unusably slow/unresponsive)
On /interactivelens, touch dragging the mass and slider also doesn't work (or is unusably slow/unresponsive)
The interactive lens functionality is a cpu bound task. It works fluent in tablet mode for desktop. This is not a problem with the website rather a limitation of the hardware.
If it is cpu bound, seems it must be triggering computations too frequently, eg once per touch event, when it should be triggering much less frequently ?
From: Aditya Yadav @.> Sent: Wednesday, August 2, 2023 10:36:49 AM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
On /interactivelens, touch dragging the mass and slider also doesn't work (or is unusably slow/unresponsive)
The interactive lens functionality is a cpu bound task. It works fluent in tablet mode for desktop. This is not a problem with the website rather a limitation of the hardware.
— Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1661755209, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQIZ4F6MHI6SXJGRRIW3XTIGSDANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
The previous developer for this site seems to have created a personal library implementation for it. But changing it for mobile specific event will require a rewrite or major changes to it.
This can't be right, moving the mass with touch works fine in the original version (dm.sharingresearch.com) - you must have broken something?
I didn't change any logic in the code I have been some minor js and CSS tweaks.
It works fluently on my phone
If it works on phone it can’t be a cpu power issue. It seems to sometimes work better than others. I suspect the underlying issue is how updates are triggered from touch events. It does seem to be specific to tablet touch.
From: Aditya Yadav @.> Sent: Wednesday, August 2, 2023 3:47:50 PM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
I didn't change any logic in the code I have been some minor js and CSS tweaks.
[Screenshot_20230802-191550]https://user-images.githubusercontent.com/96418027/257833591-1aed1035-cfb5-4875-a72a-80633d29fc93.png
It works fluently on my phone
— Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1662246864, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQIYIPHHFU7J4LXCS2VTXTJLANANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
I force restarted Safari, and then worked ok. Weird.
From: Antony Lewis @.> Sent: Wednesday, August 2, 2023 4:22:55 PM To: CosmoPars/huntfordm @.>; CosmoPars/huntfordm @.> Cc: Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
If it works on phone it can’t be a cpu power issue. It seems to sometimes work better than others. I suspect the underlying issue is how updates are triggered from touch events. It does seem to be specific to tablet touch.
From: Aditya Yadav @.> Sent: Wednesday, August 2, 2023 3:47:50 PM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
I didn't change any logic in the code I have been some minor js and CSS tweaks.
[Screenshot_20230802-191550]https://user-images.githubusercontent.com/96418027/257833591-1aed1035-cfb5-4875-a72a-80633d29fc93.png
It works fluently on my phone
— Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1662246864, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQIYIPHHFU7J4LXCS2VTXTJLANANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
(The help button text stil does not show correctly on landscape iPad)
If it works on phone it can’t be a cpu power issue. It seems to sometimes work better than others. I suspect the underlying issue is how updates are triggered from touch events. It does seem to be specific to tablet touch. … ____ From: Aditya Yadav @.> Sent: Wednesday, August 2, 2023 3:47:50 PM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1) I didn't change any logic in the code I have been some minor js and CSS tweaks. [Screenshot_20230802-191550]https://user-images.githubusercontent.com/96418027/257833591-1aed1035-cfb5-4875-a72a-80633d29fc93.png It works fluently on my phone — Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQIYIPHHFU7J4LXCS2VTXTJLANANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
Tablet cpu are more often than not worse than modern phones. My phone is high spec I just checked on it to see if it was a wrong trigger of query or javascript code bug.
I force restarted Safari, and then worked ok. Weird. … ____ From: Antony Lewis @.> Sent: Wednesday, August 2, 2023 4:22:55 PM To: CosmoPars/huntfordm @.>; CosmoPars/huntfordm @.> Cc: Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1) If it works on phone it can’t be a cpu power issue. It seems to sometimes work better than others. I suspect the underlying issue is how updates are triggered from touch events. It does seem to be specific to tablet touch. ____ From: Aditya Yadav @.> Sent: Wednesday, August 2, 2023 3:47:50 PM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1) I didn't change any logic in the code I have been some minor js and CSS tweaks. [Screenshot_20230802-191550]https://user-images.githubusercontent.com/96418027/257833591-1aed1035-cfb5-4875-a72a-80633d29fc93.png It works fluently on my phone — Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQIYIPHHFU7J4LXCS2VTXTJLANANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
Refresh might fixes many issues some times
Also on desktop some fonts now look much smaller than they were originally, and there's now overlap here
Also on desktop some fonts now look much smaller than they were originally, and there's now overlap here
* note scroll bars have appeared, so looks like something wrong with page size layout.
It is looking smaller because there is not enough height to display both the image and text. And the screen size you are viewing at i don't see where i can put the text so that it does not conflict with the image. I can fold it but it will increase the text overall height and it still might overlap with the image.
I can show a warning saying screen height is too low if you see it as a better option.
Presumably the images should just scale so that things fit?
From: Aditya Yadav @.> Sent: Thursday, August 3, 2023 3:26:59 PM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
I can show a warning saying screen height is too low if you see it as a better option.
— Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1663983748, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI44ERJLT3ONFP4RZ73XTORKHANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
(The screen shot I sent looked fine in the original version)
From: Antony Lewis @.> Sent: Thursday, August 3, 2023 4:10:18 PM To: CosmoPars/huntfordm @.>; CosmoPars/huntfordm @.> Cc: Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
Presumably the images should just scale so that things fit?
From: Aditya Yadav @.> Sent: Thursday, August 3, 2023 3:26:59 PM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
I can show a warning saying screen height is too low if you see it as a better option.
— Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1663983748, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI44ERJLT3ONFP4RZ73XTORKHANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
Presumably the images should just scale so that things fit? … ____ From: Aditya Yadav @.> Sent: Thursday, August 3, 2023 3:26:59 PM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1) I can show a warning saying screen height is too low if you see it as a better option. — Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI44ERJLT3ONFP4RZ73XTORKHANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
The image can not scale as it is the background image and is predefined with its location and size.
https://github.com/aadi58002/huntfordm/blob/main/apps/grav-lensing/src/assets/img/stackingstill4.png https://github.com/aadi58002/huntfordm/blob/main/apps/grav-lensing/src/assets/img/stackingstill3.png https://github.com/aadi58002/huntfordm/blob/main/apps/grav-lensing/src/assets/img/stackingstill2.png https://github.com/aadi58002/huntfordm/blob/main/apps/grav-lensing/src/assets/img/stackingstill.png
It is fine (and with no scroll bars) on the original so this must be something you have changed. You should try to fix things rather than trying to find reasons why they can't be fixed.
It is fine (and with no scroll bars) on the original so this must be something you have changed. You should try to fix things rather than trying to find reasons why they can't be fixed.
It should resize according to the height of the available screen now.
(The help button text still does not show correctly on landscape iPad)
I also looked into this but i can still see reproduce this issue. It tested it on both landscape and portrait modes.
Feedback from key external tester who will be hosting site.
-- It might be worth pointing out to him that the background images on those pages are the first frame of the videos that start playing (which is the last frame of the previous page's video).
This images are pre loaded when the title screen loads, and the idea is that, while the video is loading, the background image immediately displays so that there isn't a flicker of a white or purple screen before the video starts playing.
Therefore, the video and image need to remain perfectly aligned, any misalignment appears as a flicker.
On Fri, 4 Aug 2023, 16:52 Shaun Hotchkiss, @.**@.>> wrote: It's better, but the stacking animation still has the flicker on any screen size, because the background image and video aren't perfectly aligned, and on a screen larger than 1080p the background image still leaks out from behind the animation like this: [image.png]
I think something he has done limits the video to 1080p, because it doesn't grow to fill the screen beyond that.
The flicker is also very important (to me at least). It looks amateur when you open a page and get that flicker, instead of a seamless transition from one page to the next.
It's also straightforward to re-size the screen to get something like this happening:
[image.png] (however this was also true in the original... see e.g. the exact same screen size on dm.sharingresearch.comhttp://dm.sharingresearch.com below)
[image.png]
On Fri, 4 Aug 2023 at 16:07, Antony Lewis @.**@.>> wrote: Hiking today, but at a quick look todays build looks pretty decent on ipad landscape.
If you can give me your email I can forward with screenshots.
This is what I see on iPad for help button pop up.
If you can give me your email I can forward with screenshots.
aadi58002@gmail.com
The help box close button issue should be fixed now
Hello, I'm the "key external tester who will be hosting site" that cmbant mentioned earlier. Thanks for doing all this work.
With the galaxy stacking animation pages, in the current version, you appear now to have just removed the background images that had the grid of galaxies, and stacked images (i.e. on pages like: https://huntfordm-aadi58002.vercel.app/tutorial/stackedgalaxies2). This makes the screen flicker when one loads each new page, because for a tiny fraction of a second the grid disappears. In the original version this effect was minimised because the background image was changed to one with the grid in it (and these background images were pre-loaded when someone loads the app itself). While the app didn't work well on mobile, at least on desktop the experience was pleasant. Ideally, we would still have the background images with the grid in them, but they would rescale exactly how the video rescales, so that on any screen the grid in the image and the grid in the video are placed precisely on top of each other. In the dm.sharingresearch.com version this was what happened on any screen size.
I think cmbant and I have a difference in opinion about how we should warn people about mobile devices. I prefer the warning on the loading screen, i.e. how it was before, where perhaps we could also give an instruction to tell people to put their device in landscape mode. This way the warning is given once, to all mobile users, and they can carry on. I don't like the new method, which doesn't warn anyone in advance, and then repeatedly warns on every new screen later on.
On this page: https://huntfordm-aadi58002.vercel.app/tutorial/mass the page opens without the light rays bending now. I'm confused as to why, because as soon as one clicks on the slider they bend, even if you don't move the slider. Again, on the https://dm.sharingresearch.com/tutorial/mass version the rays are bent as soon as the page opens.
Thanks for testing the site repeatedly.I have tried to do the best i can to look for bugs and but i don't have a tablet device so there were many which i didn't notice.
As for the first point about video and the background image. You are correct that I replaced the background image to a pure galaxy image without the grid. I didn't see any way for the background image and the video to be resized together. Since both grow and shrink at different rates. As the video does not have enough space below it to show all the tutorial text which is shown there (image below). In this case either the video has to shrink or overlap with the image will occur. If you have a solution in mind please let me know.
Regarding the second point. I can convert the popup so that it is just a warning text which does not obstruct the rest of the website (image below).I think a non obstructive popup like this should work as a warning.If i was a user of the site i also won't want to keep clicking the cross sign on near the top each time a new page occurs ( just personal opinion ).
I fixed the snapping of light beams on the desktop page and minimize it on the tablet size page. I try to remove it from the tablet size page as well.
On Sat, 5 Aug 2023 at 01:19, shaunhotchkiss @.***> wrote:
Hello, I'm the "key external tester who will be hosting site" that cmbant mentioned earlier. Thanks for doing all this work.
With the galaxy stacking animation pages, in the current version, you appear now to have just removed the background images that had the grid of galaxies, and stacked images (i.e. on pages like: https://huntfordm-aadi58002.vercel.app/tutorial/stackedgalaxies2). This makes the screen flicker when one loads each new page, because for a tiny fraction of a second the grid disappears. In the original version this effect was minimised because the background image was changed to one with the grid in it (and these background images were pre-loaded when someone loads the app itself). While the app didn't work well on mobile, at least on desktop the experience was pleasant. Ideally, we would still have the background images with the grid in them, but they would rescale exactly how the video rescales, so that on any screen the grid in the image and the grid in the video are placed precisely on top of each other. In the dm.sharingresearch.com version this was what happened on any screen size.
I think cmbant and I have a difference in opinion about how we should warn people about mobile devices. I prefer the warning on the loading screen, i.e. how it was before, where perhaps we could also give an instruction to tell people to put their device in landscape mode. This way the warning is given once, to all mobile users, and they can carry on. I don't like the new method, which doesn't warn anyone in advance, and then repeatedly warns on every new screen later on.
On this page: https://huntfordm-aadi58002.vercel.app/tutorial/mass the page opens without the light rays bending now. I'm confused as to why, because as soon as one clicks on the slider they bend, even if you don't move the slider. Again, on the https://dm.sharingresearch.com/tutorial/mass version the rays are bent as soon as the page opens.
— Reply to this email directly, view it on GitHub https://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1666098074, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW7TR254A7CSZRX3DIVTLMTXTVG6BANCNFSM6AAAAAA2TY3HCA . You are receiving this because you authored the thread.Message ID: @.***>
-- Aditya Yadav @.***
As for the first point about video and the background image. You are correct that I replaced the background image to a pure galaxy image without the grid. I didn't see any way for the background image and the video to be resized together. Since both grow and shrink at different rates. As the video does not have enough space below it to show all the tutorial text which is shown there (image below). In this case either the video has to shrink or overlap with the image will occur. If you have a solution in mind please let me know.
I don't fully understand this issue. On the original, they both take up the full screen and rescale exactly the same, and the tutorial text fits beneath the grid. On a smaller screen, would it not work to just shrink the text so that it still fits under the grid? Or is the issue not so much smaller screen size, but different screen dimension? (i.e. if the screen is too wide?)
If I understand correctly from looking at the images, what you've done is move the video up a bit, so that there is always room underneath it for the text and button. In principle that's fine as a solution. Could the exact same re-positioning not be done for the images that have the grid and are pre-loaded?
So, could there be the normal background image (i.e. the one that is present on most screens) at the back of the screen. Then placed on top of that, the translated and rescaled images that have the grid in them (the ones that are the first frame of the video and are pre-loaded). Can that be done so that the video and image rescale on top of each other?
As for the first point about video and the background image. You are correct that I replaced the background image to a pure galaxy image without the grid. I didn't see any way for the background image and the video to be resized together. Since both grow and shrink at different rates. As the video does not have enough space below it to show all the tutorial text which is shown there (image below). In this case either the video has to shrink or overlap with the image will occur. If you have a solution in mind please let me know.
I tried to do that at first but doing that will either result in video going clipping at the top or the text size being too small to read. The below amount of text can't be resized to be both readable and fit in the space below the video. Also the button need space so that they don't overlap with the text.
I don't fully understand this issue. On the original, they both take up the full screen and rescale exactly the same, and the tutorial text fits beneath the grid. On a smaller screen, would it not work to just shrink the text so that it still fits under the grid? Or is the issue not so much smaller screen size, but different screen dimension? (i.e. if the screen is too wide?)
If I understand correctly from looking at the images, what you've done is move the video up a bit, so that there is always room underneath it for the text and button. In principle that's fine as a solution. Could the exact same re-positioning not be done for the images that have the grid and are pre-loaded?
I made so that the video resizes relative to the max possible width it can have. Then its height changes according to aspect ratio.
So, could there be the normal background image (i.e. the one that is present on most screens) at the back of the screen. Then placed on top of that, the translated and rescaled images that have the grid in them (the ones that are the first frame of the video and are pre-loaded). Can that be done so that the video and image rescale on top of each other?
That is a good idea i tried it. It reduced the flicker but there is still a very small flicker where the first bg is loaded first then the send bg and then the video.
It is looking quite playable on iPad, I think the alignment in the winning page is a bit off though
(Worse on portrait, button widths wrong)
I fixed the game page.
Thanks
I made so that the video resizes relative to the max possible width it can have. Then its height changes according to aspect ratio.
This doesn't sound the best solution - video does not have to have max possible with if a smaller width would improve vertical layout?
When everything is working, please make a PR with the changed code and I can clear the payment.
This doesn't sound the best solution - video does not have to have max possible with if a smaller width would improve vertical layout?
I don't get what you mean here in which case will it be better if video didn't occupy the complete width.
( It also shows a warning in portrait mode that landscape has a better experience )
The screen shot looks like landscape but showing the warning?
Didn’t you accept he job offer on upwork? I got a message that it expired.
From: Aditya Yadav @.> Sent: Sunday, August 6, 2023 3:38:25 PM To: CosmoPars/huntfordm @.> Cc: Antony Lewis @.>; Comment @.> Subject: Re: [CosmoPars/huntfordm] Question: Support for vertical/horizontal/both support. (Issue #1)
This doesn't sound the best solution - video does not have to have max possible with if a smaller width would improve vertical layout?
I don't get what you mean here in which case will it be better if video didn't occupy the complete width.
( It also shows a warning in portrait mode that landscape has a better experience ) [image]https://user-images.githubusercontent.com/96418027/258645813-77a3002a-a928-4b96-b48e-2f2962840813.png
— Reply to this email directly, view it on GitHubhttps://github.com/CosmoPars/huntfordm/issues/1#issuecomment-1666863354, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI7ELVLVGTRSLNEFQMLXT6M5DANCNFSM6AAAAAA2TY3HCA. You are receiving this because you commented.Message ID: @.***>
I don't get what you mean here in which case will it be better if video didn't occupy the complete width.
I guess the problem would come with very wide screens in landscape mode (typical of most cellphones nowadays) where by occupying the full width, the video can no longer fit vertically.
You and cmbant have the contract here, so I won't involve myself in what is/isn't in scope, but the long term solution in such a situation would probably be to have the video play on the left 50% of the screen and the text/buttons appear on the right.
The screen shot looks like landscape but showing the warning?
I'm not sure we can tell for sure, as we can't see the full screen in Aditya's screenshot. It could continue down much further. In any case, I think the warning message kicks in based on screen width, independently of the orientation. That's probably desired though, as a very small landscape screen still won't have a good experience.
As mentioned in the upwork request i have started added tablet support to the site. But here i am not sure if the support you mention is for the iPad vertical mode or horizontal mode ( landscape mode )
I currently added and tested home,star,direct,obstacle,mass,newdarkmatter,darkmatter,interactivelens,slrare pages on the https://github.com/aadi58002/huntfordm/commit/136d755337da9472b660f282fa9041d0d47d6090 commit
Can you clarify the target device dimensions? Also can you look at the commit and clarify if you want me to keep working on this or should i change any type of styling choices which i have made in code.