CosmoStat / shear-pipe-peaks

The impact of systematic errors on weak-lensing peak counts for CFIS
2 stars 3 forks source link

Covariance matrix for peaks #1

Open viajani opened 3 years ago

viajani commented 3 years ago

Description of the issue

This is meant to discuss how to properly compute the covariance matrix:

The current covariance matrix for peak counts looks like this: covariance_peaks

with condition number ~ 10^4.

List of tasks to do within this issue:

1) Plot constraints with rescaled covariance 2) Plot constraints without rescaled covariance

viajani commented 3 years ago

1. Plot constraints with rescaled covariance

Constraints_with_correction

2. Plot constraints without rescaled covariance constraints_without_cov_correction

pettorin commented 3 years ago

hi @viajani thanks, I have a couple of questions to better understand what you are doing:

viajani commented 3 years ago

hi @pettorin

where x and mu are the peak counts for the massless cosmology of the MassiveNus simulations and the average is over the 10000 different realisation of such cosmology. The rescaling factor is only a multiplicative pre-factor in front of the covariance as *f_sky Cov** where for the size of our maps and CFIS sky coverage is 12.25/5000.

However, since we are using real data and these are not forecast I am not sure if using a rescaling is fair.

I can compute the corresponding single redshift case (non-tomo) for Euclid forecast for a more fair comparison (but I guess that the huge bias shown here won't depend on that)

image

viajani commented 3 years ago
  1. Try to extract several patches (not just one as I am doing now) and then sum/average the peak counts, then rescale the covariance for the area covered by those patches
viajani commented 3 years ago

Output for data array obtained by extracting 10 patches from the "big" data map, computing the peaks on each one of the 10 patches and then taking the average. In this way the covariance is rescaled as: f_rescale=12.25/122.5 where 12.25 deg^2=size of a single map and 122.5 deg^2=coverage of the 10 patches

image

viajani commented 3 years ago

next: test the difference when increasing number of patches (try to take as many as I can extract)

pettorin commented 3 years ago

thanks @viajani: the plot above looks strange, Omegam is too high, it was actually already very high in the first plot (I hadn't noticed) when you had with 1 patch, but now with more patches it's getting even worse. Could you please remind me if the first plot above was already with peaks or was it from the PS? Did you check what you get with the PS before moving to peaks? It may just be that this is entirely dominate by (neglected) systematics or it might be something else which is wrong.

pettorin commented 3 years ago

Also, which are the units of As here?

viajani commented 3 years ago

Hi @pettorin , the units of As are 10^9*A_s while concerning the comparison with the PS I had opened the issue about this https://github.com/CosmoStat/shear-pipe-peaks/issues/3 and corresponding notebook https://github.com/CosmoStat/shear-pipe-peaks/blob/main/notebooks/compute_powerspectrum.ipynb but when I showed it during the last telecon I remember @martinkilbinger @aguinot explained me that it was even more complicated to get the contours with the Power Spectrum and that if we want to do second order statistics we should consider pseudo-Cls or COSEBIs, can you confirm on this @aguinot @martinkilbinger ?

aguinot commented 3 years ago

I don't know if it is more complicated to get contours using a power spectrum but I don't know why you first make a map and derive the PS from it when you can measure it directly from the catalogue. I feel like you would loose some informations.

Regarding your approach with multiple patch one problem you might have here might be due to masking. With one patch you have a problem at the border once, with 10 patches you have it 10 times.. Also the smaller the patch the more you will have effects at the borders.

Is there a way to test for the systematics (like the COSEBIs for the PS) on the mass maps? May be the smoothing scale is to small and you have only noise on your map..

viajani commented 3 years ago

Test to do discussed during 18/02 telecon:

  1. Exclude extreme peaks: reduce number of bins to avoid bins with very few peaks.
  2. See how the contours shift for larger scales, plot contours corresponding to different smoothing
  3. Get constraints with full sky coverage rescaling for CFIS but with the 10 patches

N.B.