search

CottageLabs / idfind

An identifier identifier
1 stars 0 forks source link

Identifier component crashes if invalid service URL supplied with Test #3

Closed emanuil-tolev closed 12 years ago

emanuil-tolev commented 12 years ago

identifier.py crashes if the test it's trying to run has an invalid service URL recorded - e.g. url_prefix is "http://service.site.com/" instead of "http://dx.doi.org/". The error looks like a standard failure - the URL just doesn't exist (and the code just doesn't handle it :) ).

emanuil-tolev commented 12 years ago

fixed in commit 050d634

my new handling isn't perfect, just doesn't let the exception crash the whole page... makes the service URL check return false if an URLError is raised