search

Covid19Efforts / covidshots

covidshots.in helps you find, and book vaccination slots in India. You can set it to automatically book new slots, or just to monitor for new slots and sound alarm.
https://covidshots.in/?
2 stars 5 forks source link

When a new mobile number if used for booking the list of users to autobook form previous mobile is persisted #19

Open lihas opened 3 years ago

lihas commented 3 years ago

Because of this our code tries to find user details from g_persistent_vars.g_booking_state_users_details_get(). We are not clearing user details so im not sure why his would be an issue. would have to debug more. The essence of the issue is that once a new mobile number is used it causes issues with older cached data. We can fix this issue in one of the two ways.

  1. Make details stored with mobile number, ie. objects referenced with mobile numbers
  2. Clear mobile number specific info when a new mobile number is seen.

2 is easier to implement and will go with it.

lihas commented 3 years ago

Repro steps.

  1. Login with mobile number 1, set auto book settings
  2. logout
  3. login with another mobile number. set auto book settings for some other user, and run autobook. You will see older autobook cached info causing issues in code.
lihas commented 3 years ago

@damayantianand This is one of the 3 issues we found yesterday. I have submitted the fix. will check for repro and close