Crazy-Crew / CrazyEnvoys

Drop custom crates with any prize you want all over spawn for players to fight over.
https://modrinth.com/plugin/crazyenvoys
MIT License
41 stars 32 forks source link

[Bug Report]: Item Book Enchantments applied improperly #112

Closed Firestar311 closed 7 months ago

Firestar311 commented 1 year ago

Spark link

No response

Server Version

1.19.4

Server Platform

Paper

Describe the bug

Enchantments are applied in the wrong way on Enchanted Books When applying enchantments to enchanted books, you need to use the EnchantmentStorageMeta in order for the books to be able to be used in Anvils. I am a Sr Dev for a server and we discovered this from our players. I took a look at your code and figured that out Also, Here are some NBT Screenshots of what is actually the problem The first one here is taken from the vanilla creative mode and is what it should be: Screenshot This one here is what it actually looks like from this plugin: Screenshot This is fine for normal items, but enchanted books need to be under the "StoredEnchantments" using the linked meta above

Steps to reproduce

Have a tier with an item that has it set up like this: 'Item:Enchanted_Book, Mending:1, Amount:1' Start and envoy and find one with a book Attempt to apply the book to an item in an anvil See it not work

Additional context

No response

Agreements

ryderbelserion commented 1 year ago

I thought this was CrazyEnchantments for some reason. Ignore the previous stuff...

TrueDarkLord commented 1 year ago

As far as I know, we just don't have enchanted book support. You can always use the command section for it.