search

Crazyht / ngx-tree-select

Angular select component with tree items
https://crazyht.github.io/ngx-tree-select/
MIT License
56 stars 45 forks source link

Set ModuleWithProviders type (Angular 10+ support) #204

Closed Nokhoneryu closed 3 years ago

Nokhoneryu commented 3 years ago

From Angular 10 onward, to set a type to the ModuleWithProviders is now mandatory. With this simple alteration, the library becomes Angular 10+ compatible.

Crazyht commented 3 years ago

This signature already exists on old version of angular ?

Nokhoneryu commented 3 years ago

In the previous version, is optional, so it's backwards compatible.

Nokhoneryu commented 3 years ago

Also, i noticed there are 2 peer dependencies to old versions:

"@angular/core": ">=4.0.0 <6.0.0", "@angular/forms": ">=4.0.0 <6.0.0"

I tried with the angular version 11.1.1 and all worked just fine, so we might as well bump this peer dependencies, what do you think @Crazyht ?

Crazyht commented 3 years ago

Yes, we probably can change this old deps :P

Nokhoneryu commented 3 years ago

Alright, just updated the package.json to match the latest version of angular :)