Crystal-Nest / soul-fire-d

Let Soul Fire burn!
https://modrinth.com/mod/soul-fire-d
GNU General Public License v3.0
5 stars 2 forks source link

Minor irks about enchants #25

Closed anoomolu closed 1 year ago

anoomolu commented 1 year ago

Describe the bug 1 -Soul Fire Aspect doesn't spawn in Bastions, while Soul Flame does.

2 -Soul Flame and Soul Fire Aspect aren't marked as Treasure enchants (like Mending, Frost Walker etc.). I appreciate that they show up in the enchanting table, but considering they're pretty strong and are supposed to be found in Bastions (mid to late game structures), I feel like they're better suited to be treasure-only by default.

To Reproduce Steps to reproduce the behavior (1):

  1. Go to bastion_other_loot_modifier.json in data.

Expected behavior I'd expect to find entries for both Soul Flame and Soul Fire Aspect. Only the former has one.

Screenshots Adding the below enables both to spawn, albeit very rarely imo. image

System information:

Additional context Not really context but more a thank you for making this mod, I love the attention to detail and compatibility this has with other mods ^^

Crystal-Spider commented 1 year ago

Thank you for your kind words and the support! Let me reply in order:

  1. It's intentional, Soul Fire Aspect can spawn on swords found in chests, you cannot find the book. That's also why it's not present in this mod datapack, Minecraft Vanilla already enchants randomly the swords based on all registered suitable enchantments.
  2. Some versions ago they were by default tresure enchantments, but I changed it after another request. To be honest if it was for me all enchantments would be available in the enchanting table, but regardless of my personal taste what I can do is add new configuration options that let tweak the soul enchantments more than it's currently possible, so that each player can have the customization they prefer. It will come along with version 3.2.0.0 and data driven fires (a feature I'm working on to let people register fires of other mod without needing to make a mod themselves, just a datapack)

Thank you again!

Crystal-Spider commented 1 year ago

Version 3.2.0.0 is now out, along with the new configuration options!