search

Crystal-Nest / soul-fire-d

Let Soul Fire burn!
https://modrinth.com/mod/soul-fire-d
GNU General Public License v3.0
5 stars 1 forks source link

Soul Flame on crossbows #38

Open Vic-PT opened 5 months ago

Vic-PT commented 5 months ago

Soul flame, acts like regular flame on crossbows.

Would realy like it if the soul flame enchantment worked correctly on crossbows, making the flame blue and causing soul burning. I'm not asking for soul flame to be compatible with crossbows, I already have a mod for that.

I'm using universal enchants to get the soulflame enchantment on the crossbow.

Crystal-Spider commented 5 months ago

I understand, I also know what the problem is.
Unfortunately, blame Mojang for this, Flame injects its code directly into the Bow item rather than the Flame enchantment itself (unlike Fire Aspect where the effect is handled by the enchantment).
This means that to make Soul Flame apply to bows I had to change the Bow code.
I'll check how Universal Enchants applies flame to crossbows and I'll see if it's something that should be fixed on my end or on their end.

Crystal-Spider commented 5 months ago

Speaking with Universal Enchants author, it's currently not possible to make Soul Flame compatible.
However, he said he will update his mod to allow this, and then I'll have to update mine too.
Until then, this issue can't be solved.

Crystal-Spider commented 1 month ago

Update: Universal Enchants author told me that its change is ready but not released yet, and that he will notify me when it'll be available.