search

Crystal-Nest / soul-fire-d

Let Soul Fire burn!
https://modrinth.com/mod/soul-fire-d
GNU General Public License v3.0
5 stars 3 forks source link

Appropriate incompatible enchantments #43

Closed polykatt closed 4 months ago

polykatt commented 4 months ago

I have confirmed no other issue asks for this

Other mod

Simple Enchantments by InfernalEclipse

Current behavior

The Simple Enchantments mod adds "hail" for bows. The enchantment is incompatible with flame (as it freezes the target) but not so with soul flame.

Desired behavior

Have soul flame enchantment be incompatible with hail

Stacktrace and logs

No response

Additional context

No response

Crystal-Spider commented 4 months ago

I'd say to ask the other mod author to add this feature.

Soul Flame enchantment extends the base Flame enchantment and uses the same compatibility check with extra narrowing conditions.
I guess, on their side, compatibility with their Hail enchantment is computed by checking if the other enchantment is Flame rather than checking the Java class, so Soul Flame doesn't get detected properly by them.

Furthermore, their code is not open source, so it's harder for me to add compatibility than it is for them.

Crystal-Spider commented 4 months ago

They replied to your issue here, I'm closing this.