Crystal-Nest / soul-fire-d

Let Soul Fire burn!
https://modrinth.com/mod/soul-fire-d
GNU General Public License v3.0
5 stars 2 forks source link

[Discord] How to DDFire at Forge 1.18.2-4.0.1 #45

Closed Crystal-Spider closed 2 months ago

Crystal-Spider commented 2 months ago

I have confirmed no other issue reports this bug

I have confirmed the mod is installed on the proper side

Current behavior

Hello, first of all thanks for still supporting 1.18.2, big respect.

I'm a modpack maker. I just updated Soul Fire'd to 1.18.2-4.0.1 (Forge)

BYG has not backported built-in compatibility with Soul Fire'd yet, so you still have to use data-driven fires or register manually.

After updating to Soul Fire'd to a version that uses Cobweb, DDFire stopped working. I noticed that the mod ID is now soul_fire_d. I change the path accordingly, but it still doesn't work.

This is the JSON file for datapack fires:

{
  "mod": "byg",
  "fires": [
    {
      "fire": "cryptic",
      "damage": 3.5,
      "invertHealAndHarm": false
    },
    {
      "fire": "boric",
      "damage": 3.5,
      "invertHealAndHarm": false
    }
  ]

}

It has the path: data\soul_fire_d\fires\big_fires.json

Expected behavior

Data Driven Fires should be backwards compatible and work the same as before.

Steps to reproduce

No response

Minecraft version

1.18.2

Mod loader version

Forge 40.2.0

Mod version

4.0.1

Other mods

Stacktrace and logs

No response

Additional context

Issue created from Discord: forum post.

Crystal-Spider commented 2 months ago

Replicated, affects all supported Minecraft versions.

This is due to a NPE thrown when attempting to register null fire components for the enchantments.
Furthermore, on Forge there is a problem with the networking API and a workaround is needed.

Should be able to fix and release by today.