Crystal-Nest / soul-fire-d

Let Soul Fire burn!
https://modrinth.com/mod/soul-fire-d
GNU General Public License v3.0
5 stars 2 forks source link

Crash on start (again) #5

Closed entusiastaIA closed 1 year ago

entusiastaIA commented 1 year ago

Describe the bug I've seen this has happened before, but cannot know the reason. On latest Fabric 1.18.2 version (and previous one), 1.1.0.0 (and 1.0.0.2), if I add the mod i cannot launch minecraft.

Captura

Crystal-Spider commented 1 year ago

The reason of the crash is similar, but different.
Basically another mod is trying to modify the same part of the code I do, and so it crashes.
The incompatible mod is sihywtcamd (So I heard you were talking crap about Minecraft's difficulty?).

Anyway, using the latest versions of Soul Fire'd and sihywtcamd I can't replicate the issue (my game launches) for 1.19.2.
Using 1.18.2 I can replicate the issue, but it's likely an issue of sihywtcamd: most probably its latest 1.18.2 version does not include commit c032277b48b02a09d38efd957e3c99c23f550d6f that fixed incompatibility with other mods.

I opened a new issue on the other mod GitHub.

entusiastaIA commented 1 year ago

Thank you very much for taking the time to check it this much! Could that issue with that mod affect other one's too? I am trying to narrow down random crashes I am getting that afterwards leave the world unloadable.

I can confirm that removing sihywcamd and enabling back SoulFire'd allow me to run the game again.

Crystal-Spider commented 1 year ago

Definitely this issue can affect other mods, but only if other mods are changing something in the behavior of a Zombie attack.
On my end I cannot do anything to fix this, it's up to sihywcamd to fix that by porting the fix that's already in 1.19.2 to 1.18.2.

If it's fine for you, I'd close this issue and you can follow the progress on the other issue I opened on sihywcamd.

entusiastaIA commented 1 year ago

Perfect thank you!

charlyb01 commented 1 year ago

Hello, I'm going to update the 1.18 version to get the fix then. Sorry for that, I noticed it a bit late so it stayed on this version! [Edit] Done!

entusiastaIA commented 1 year ago

Thank you very much, I updated and it is working! :)