search

Crystal-Nest / soul-fire-d

Let Soul Fire burn!
https://modrinth.com/mod/soul-fire-d
GNU General Public License v3.0
5 stars 3 forks source link

Crash when hitting with torch #59

Closed Disketaa closed 1 week ago

Disketaa commented 1 week ago

I have confirmed no other issue reports this bug

I have confirmed the mod is installed on the proper side

Current behavior

When you hit someone with torch it crashes the game (Probably conflict with some other my mods maybe with "Amendments")

Expected behavior

No crash

Steps to reproduce

Equip torch in hand Attack a mob

Minecraft version

1.21.1

Mod loader version

0.16.5

Mod version

5.0.4

Other mods

Fabric Mods: 
    a_good_place: A Good Place 1.21-1.2.4
    accurateblockplacement: Accurate Block Placement 1.2.5
    achiopt: AchievementOptimizer 1.21.1-1.2.0
    amendments: Amendments 1.21-1.2.14
    architectury: Architectury 13.0.6
    bbm: BetterBoatMovement 2.2.4-1.21+fabric
      dev_nyon_konfig: konfig 2.0.2-1.20.4
    betterclouds: Better Clouds 1.7.4+1.21-fabric
    betterf3: BetterF3 11.0.2
      fabric-resource-loader-v0: Fabric Resource Loader (v0) 1.3.0+565991296a
    bookshelf: Bookshelf 21.1.10
    bridgingmod: Bridging Mod 2.5.0+1.21.1
    bsvsb: Better Sodium Video Settings Button 4.0.0-alpha.0
    chat_heads: Chat Heads 0.13.3
    chatanimation: ChatAnimation 1.0.6
    chatcalc: ChatCalc 4.1.6
    chunksfadein: Chunks Fade In 1.0.3-1.21
      com_moandjiezana_toml_toml4j: toml4j 0.7.2
      crowdin-translate: CrowdinTranslate 1.0.0
    clearvoid: Clear Void 1.3.0
    clickthrough: ClickThrough Plus 3.0+1.21
    clientsort: ClientSort 1.0.0
    cloth-config: Cloth Config v15 15.0.140
      cloth-basic-math: cloth-basic-math 0.6.1
    cobweb: Cobweb 1.1.3
    connected-doors: Connected Doors 1.3+1.21
    coppernugget: The Missing Nugget 1.21.1-1-fabric
    creativecore: CreativeCore 2.12.16
      net_neoforged_bus: bus 7.2.0
    custom_piglin_bartering: Custom Piglin Bartering 1.3.1
    datareload: Data Reload 1.7
    debugify: Debugify 1.21.1+1.0
    donthidethetooltip: DontHideTheTooltip 1.0+1.21.1
    drippyloadingscreen: Drippy Loading Screen 3.0.8
    easyanvils: Easy Anvils 21.1.0
    easymagic: Easy Magic 21.1.0
    eatinganimationid: Eating Animation 1.21+1.9.72
    effectdescriptions: Effect Descriptions 21.1.0
    eg_particle_interactions: Particle Interactions 0.2
    elytratrims: Elytra Trims 3.5.4
      conditional-mixin: conditional mixin 0.6.2
      mixinsquared: MixinSquared 0.1.2-beta.4
    emi: EMI 1.1.16+1.21.1+fabric
    emi_loot: EMI Loot 0.7.4+1.21+fabric
    enchdesc: EnchantmentDescriptions 21.1.4
    enhanced_attack_indicator: Enhanced Attack Indicator 1.1.0+1.21
    entity_model_features: Entity Model Features 2.2.6
    entity_texture_features: Entity Texture Features 6.2.5
      org_apache_httpcomponents_httpmime: httpmime 4.5.10
    entityculling: EntityCulling 1.7.0
    f3teverywhere: F3+T Everywhere 1.0.1
    fabric-api: Fabric API 0.105.0+1.21.1
      fabric-api-base: Fabric API Base 0.4.42+6573ed8c19
      fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.6.68+b559734419
      fabric-biome-api-v1: Fabric Biome API (v1) 13.0.29+5bd9f1bc19
      fabric-block-api-v1: Fabric Block API (v1) 1.0.22+0af3f5a719
      fabric-block-view-api-v2: Fabric BlockView API (v2) 1.0.10+6573ed8c19
      fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.52+0af3f5a719
      fabric-client-tags-api-v1: Fabric Client Tags 1.1.15+6573ed8c19
      fabric-command-api-v1: Fabric Command API (v1) 1.2.49+f71b366f19
      fabric-command-api-v2: Fabric Command API (v2) 2.2.28+6ced4dd919
      fabric-commands-v0: Fabric Commands (v0) 0.2.66+df3654b319
      fabric-content-registries-v0: Fabric Content Registries (v0) 8.0.16+b559734419
      fabric-convention-tags-v1: Fabric Convention Tags 2.0.23+7f945d5b19
      fabric-convention-tags-v2: Fabric Convention Tags (v2) 2.8.0+9d22c5fd19
      fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.2.29+0af3f5a719
      fabric-data-attachment-api-v1: Fabric Data Attachment API (v1) 1.1.28+1daea21519
      fabric-data-generation-api-v1: Fabric Data Generation API (v1) 20.2.20+16c4ae2519
      fabric-dimensions-v1: Fabric Dimensions API (v1) 4.0.0+6fc22b9919
      fabric-entity-events-v1: Fabric Entity Events (v1) 1.7.0+2122d82819
      fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.7.13+ba9dae0619
      fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.53+6ced4dd919
      fabric-item-api-v1: Fabric Item API (v1) 11.1.0+d5debaed19
      fabric-item-group-api-v1: Fabric Item Group API (v1) 4.1.5+3fc0e55219
      fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.47+0af3f5a719
      fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.45+df3654b319
      fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 2.3.12+6c1df36019
      fabric-loot-api-v2: Fabric Loot API (v2) 3.0.14+3f89f5a519
      fabric-loot-api-v3: Fabric Loot API (v3) 1.0.2+3f89f5a519
      fabric-message-api-v1: Fabric Message API (v1) 6.0.13+6573ed8c19
      fabric-model-loading-api-v1: Fabric Model Loading API (v1) 2.0.0+fe474d6b19
      fabric-networking-api-v1: Fabric Networking API (v1) 4.3.0+c7469b2119
      fabric-object-builder-api-v1: Fabric Object Builder API (v1) 15.2.0+40875a9319
      fabric-particles-v1: Fabric Particles (v1) 4.0.2+6573ed8c19
      fabric-recipe-api-v1: Fabric Recipe API (v1) 5.0.13+6508971219
      fabric-registry-sync-v0: Fabric Registry Sync (v0) 5.1.3+60c3209b19
      fabric-renderer-api-v1: Fabric Renderer API (v1) 3.4.0+c705a49c19
      fabric-renderer-indigo: Fabric Renderer - Indigo 1.7.0+c705a49c19
      fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 3.2.68+df3654b319
      fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.3.48+73761d2e19
      fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 3.1.6+1daea21519
      fabric-rendering-v0: Fabric Rendering (v0) 1.1.71+df3654b319
      fabric-rendering-v1: Fabric Rendering (v1) 5.0.5+df16efd019
      fabric-resource-conditions-api-v1: Fabric Resource Conditions API (v1) 4.3.0+8dc279b119
      fabric-screen-api-v1: Fabric Screen API (v1) 2.0.25+8b68f1c719
      fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.3.87+b559734419
      fabric-sound-api-v1: Fabric Sound API (v1) 1.0.23+6573ed8c19
      fabric-transfer-api-v1: Fabric Transfer API (v1) 5.3.0+d831205f19
      fabric-transitive-access-wideners-v1: Fabric Transitive Access Wideners (v1) 6.1.0+1daea21519
    fabric-language-kotlin: Fabric Language Kotlin 1.12.3+kotlin.2.0.21
      org_jetbrains_kotlin_kotlin-reflect: kotlin-reflect 2.0.21
      org_jetbrains_kotlin_kotlin-stdlib: kotlin-stdlib 2.0.21
      org_jetbrains_kotlin_kotlin-stdlib-jdk7: kotlin-stdlib-jdk7 2.0.21
      org_jetbrains_kotlin_kotlin-stdlib-jdk8: kotlin-stdlib-jdk8 2.0.21
      org_jetbrains_kotlinx_atomicfu-jvm: atomicfu-jvm 0.25.0
      org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm: kotlinx-coroutines-core-jvm 1.9.0
      org_jetbrains_kotlinx_kotlinx-coroutines-jdk8: kotlinx-coroutines-jdk8 1.9.0
      org_jetbrains_kotlinx_kotlinx-datetime-jvm: kotlinx-datetime-jvm 0.6.1
      org_jetbrains_kotlinx_kotlinx-io-bytestring-jvm: kotlinx-io-bytestring-jvm 0.5.4
      org_jetbrains_kotlinx_kotlinx-io-core-jvm: kotlinx-io-core-jvm 0.5.4
      org_jetbrains_kotlinx_kotlinx-serialization-cbor-jvm: kotlinx-serialization-cbor-jvm 1.7.3
      org_jetbrains_kotlinx_kotlinx-serialization-core-jvm: kotlinx-serialization-core-jvm 1.7.3
      org_jetbrains_kotlinx_kotlinx-serialization-json-jvm: kotlinx-serialization-json-jvm 1.7.3
    fabricloader: Fabric Loader 0.16.5
    fancymenu: FancyMenu 3.2.5
      com_github_keksuccino_japng: japng 0.5.3
      com_github_rtyley_animated-gif-lib-for-java: animated-gif-lib-for-java animated-gif-lib-1.7
    farmtweaks: FarmTweaks 1.1+1.21.1
    forgeconfigapiport: Forge Config API Port 21.1.1
    freecam: Freecam (Modrinth Edition) 1.3.0+mc1.21
    fzzy_config: Fzzy Config 0.5.2+1.21
      blue_endless_jankson: jankson 1.2.3
      fabric-permissions-api-v0: fabric-permissions-api 0.3.1
      net_peanuuutz_tomlkt_tomlkt-jvm: tomlkt-jvm 0.3.7
    glassitemframes: Glass Item Frames 1.0
    glitchcore: GlitchCore 2.1.0.0
      net_jodah_typetools: typetools 0.6.3
    globalpacks: Global Data- & Resourcepacks 21.0.0
    grindenchantments: Grind Enchantments 3.2.2+1.21-rc1
      codec-config-api: Codec config API 2.0.0+1.20.5-rc3
    hopobettermineshaft: Hopo Better Mineshaft 1.2.7
    iris: Iris 1.8.0-beta.4+mc1.21.1
      io_github_douira_glsl-transformer: glsl-transformer 2.0.1
      org_anarres_jcpp: jcpp 1.4.14
      org_antlr_antlr4-runtime: antlr4-runtime 4.13.1
    itemframetweaks: Item Frame Tweaks 2.0.1+1.21.1
    itemphysiclite: ItemPhysicLite 1.6.5
    jade: Jade 15.5.1+fabric
    java: OpenJDK 64-Bit Server VM 21
    jei: Just Enough Items 19.21.0.246
    kiwi: Kiwi Library 15.1.1+fabric
    konkrete: Konkrete 1.9.9
    letitrain: letitrain 2.2.2
    libjf: LibJF 3.17.3
      libjf-base: LibJF Base 3.17.3
      libjf-config-commands: LibJF Config Commands 3.17.3
      libjf-config-core-v2: LibJF Config 3.17.3
      libjf-config-network-v0: LibJF Config: Network 3.17.3
      libjf-config-ui-tiny: LibJF Config UI: Tiny 3.17.3
      libjf-data-manipulation-v0: LibJF Data Manipulation 3.17.3
      libjf-data-v0: LibJF Data 3.17.3
      libjf-mainhttp-v0: LibJF MainHTTP 3.17.3
      libjf-resource-pack-entry-widgets-v0: LibJF Resource Pack Entry Widgets 3.17.3
      libjf-translate-v1: LibJF Translate 3.17.3
      libjf-unsafe-v0: LibJF Unsafe 3.17.3
      libjf-web-v1: LibJF Web 3.17.3
    lithium: Lithium 0.13.1
    lychee: Lychee Tweaker 6.0.2+fabric
    melody: Melody 1.0.10
    metalfences: Metal Fences 1.0
    midnightlib: MidnightLib 1.6.3
    minecraft: Minecraft 1.21.1
    mixintrace: MixinTrace 1.1.1+1.17
    modmenu: Mod Menu 11.0.2
      placeholder-api: Placeholder API 2.4.0-pre.2+1.21
    moonlight: Moonlight Lib 1.21-2.14.27
    mousetweaks: Mouse Tweaks 2.26
    mr_datapack_reloadhelper: Datapack Reload Helper 1.1.1
    mr_dungeons_andtaverns: Dungeons and Taverns 1-v4.4.4
    mr_dungeons_andtavernsancientcityoverhaul: Dungeons and Taverns Ancient City Overhaul 1-v2
    mr_dungeons_andtavernsdeserttemplereplacement: Dungeons and Taverns Desert Temple Replacement 1-v1.2
    mr_dungeons_andtavernsendcastlestandalone: Dungeons and Taverns End Castle Standalone 1-v1.1
    mr_dungeons_andtavernsjungletemplereplacement: Dungeons and Taverns Jungle Temple Replacement 1-v1.2
    mr_dungeons_andtavernsnetherfortressoverhaul: Dungeons and Taverns Nether Fortress Overhaul 1-v2.4
    mr_dungeons_andtavernsoceanmonumentreplacement: Dungeons and Taverns Ocean Monument Replacement 1-v1.2
    mr_dungeons_andtavernspillageroutpostoverhaul: Dungeons and Taverns Pillager Outpost Overhaul 1-v2.2
    mr_dungeons_andtavernsstrongholdrework: Dungeons and Taverns Stronghold Rework 1-v2.1
    mr_dungeons_andtavernsswamphutoverhaul: Dungeons and Taverns Swamp Hut Overhaul 1-v2
    mr_dungeons_andtavernswoodlandmansionreplacement: Dungeons and Taverns Woodland Mansion Replacement 1-v1.2
    mru: Mineblock's Repeated Utilities 1.0.2+1.21+fabric
    music_delay_reducer: Music Delay Reducer 1.0.6+1.21
    nicer-skies: Nicer Skies 1.4.1+1.21.1
    no-shield-delay: No Shield Delay 1.0.1
      com_electronwill_night-config_core: core 3.8.1
      com_electronwill_night-config_toml: toml 3.8.1
    noisium: Noisium 2.3.0+mc1.21-1.21.1
    notenoughanimations: NotEnoughAnimations 1.7.6
    notenoughcrashes: Not Enough Crashes 4.4.8+1.21
    ok_zoomer: Ok Zoomer 9.3.0
      libzoomer: LibZoomer 0.10.0+1.21
      wrench_wrapper: Wrench Wrapper 0.4.0
    owo: oωo 0.12.15+1.21
      io_wispforest_endec: endec 0.1.5
      io_wispforest_endec_gson: gson 0.1.3
      io_wispforest_endec_jankson: jankson 0.1.3
      io_wispforest_endec_netty: netty 0.1.2
    paginatedadvancements: Paginated Advancements 2.5.1
    particletweaks: Particle Tweaks 1.2.1-mc1.21.1
    particular: Particular 1.1.1+1.21
    polytone: Polytone 1.21-2.4.22
      net_objecthunter_exp4j: exp4j 0.4.8
    prickle: PrickleMC 21.1.4
    puzzleslib: Puzzles Lib 21.1.18
    quickleafdecay: Quick Leaf Decay 0.2.5
    raised: Raised 4.0.0
    reeses-sodium-options: Reese's Sodium Options 1.8.0-beta.4+mc1.21.1
    resourcepackoverrides: Resource Pack Overrides 21.1.0
    respackopts: Resource Pack Options 4.11.3
      io_gitlab_jfronny_muscript-all: muscript-all 2.0.0-SNAPSHOT
      io_gitlab_jfronny_muscript-json: muscript-json 2.0.0-SNAPSHOT
    sereneseasons: SereneSeasons 10.1.0.1
    sleepwarp: SleepWarp (Updated) 2.4.0+1.21.1
      server_translations_api: Server Translations API 2.3.1+1.21-pre2
        packet_tweaker: Packet Tweaker 0.5.1+24w03b
    snowballkb: Snowball and Egg Knockback 1.3-1.21
    snowrealmagic: Snow! Real Magic! 11.0.7+fabric
    sodium: Sodium 0.6.0-beta.2+mc1.21.1
    sodium-extra: Sodium Extra 0.6.0-beta.3+mc1.21.1
    soul_fire_d: Soul Fire'd 5.0.4
    sounds: Sounds 2.1.0+1.21+fabric
      mixinextras: MixinExtras 0.5.0-beta.2
    squatgrow: Squat Grow 21.1.0+mc1.21.1
    stack-to-nearby-chests: Stack to Nearby Chests 0.5.10
      libgui: LibGui 11.0.0+1.21
        jankson: Jankson 8.0.0+j1.2.3
        libninepatch: LibNinePatch 1.2.0
    status-effect-bars: Status Effect Bars 1.0.6
    symbols_n_stuff: Symbols 'n' Stuff 0.1.2+1.21
    team_capes: Team Capes 1.1.1+1.21
    tia: Tiny Item Animations 1.2.1
    villagerconfig: VillagerConfig 4.3.0+1.21.1
      config2brigadier: Config to Brigadier 1.2.5
      fiber: fiber 0.23.0-2
    visualworkbench: Visual Workbench 21.1.0
    waveycapes: WaveyCapes 1.4.10
    wits: WITS 1.3.0+1.21-fabric
    worldplaytime: World Play Time 1.2.2
    xaerominimap: Xaero's Minimap 24.5.0
    xaeroworldmap: Xaero's World Map 1.39.0
    xaerozoomout: XaeroZoomout 2.0.0
    yet_another_config_lib_v3: YetAnotherConfigLib 3.5.0+1.21-fabric
      com_twelvemonkeys_common_common-image: common-image 3.10.0
      com_twelvemonkeys_common_common-io: common-io 3.10.0
      com_twelvemonkeys_common_common-lang: common-lang 3.10.0
      com_twelvemonkeys_imageio_imageio-core: imageio-core 3.10.0
      com_twelvemonkeys_imageio_imageio-metadata: imageio-metadata 3.10.0
      com_twelvemonkeys_imageio_imageio-webp: imageio-webp 3.10.0
      org_quiltmc_parsers_gson: gson 0.2.1
      org_quiltmc_parsers_json: json 0.2.1
    yosbr: YOSBR 0.1.2

Stacktrace and logs

https://mclo.gs/bL3CROJ

Additional context

No response

Crystal-Spider commented 1 week ago

Checking the crash log, this is a problem with Amendments.

Since 1.21, to set entities on fire with Soul Fire'd the method to use is void setOnFire(Entity, float, ResourceLocation), instead they are compiling against an older version of Soul Fire'd where the method signature was void setOnFire(Entity, int, ResourceLocation).

I suggest you open an issue in their repository, linking this issue here and tagging me.

Kloytz commented 1 week ago

Same issue

Crystal-Spider commented 1 week ago

Same issue

Same answer

Crystal-Spider commented 1 week ago

On my side I did everything and my PR has also been merged.
You just need to wait for a new version of Amendments to be released.