search

Crystal-Nest / soul-fire-d

Let Soul Fire burn!
https://modrinth.com/mod/soul-fire-d
GNU General Public License v3.0
5 stars 3 forks source link

Mixin crash with your mod and Aileron #6

Open Sunconure11 opened 2 years ago

Sunconure11 commented 2 years ago

https://github.com/LodestarMC/Aileron/issues/13

Attempting to start the two as of late causes the game to crash really early on.

Crystal-Spider commented 2 years ago

This is due to both mods trying to change the behavior of campires that normally would hurt the entity on them.
Currently the only solution I could think of is that both mods change the code from using a Redirect annotation to using ModifyExpressionValue.
However this requires both mod to add a new plugin for mixins and it's a little to much work as of now for me.
For the moment being I'm sorry but, even if Aileron adopts the new annotation, I won't and the mods will be incompatible.
However at some point in the future I will adopt the new annotation, at which point the incompatibility will depend on whether Aileron will do the same.

Crystal-Spider commented 4 months ago

With the next huge update for Soul Fire'd, I finally came back to this.
I noticed that I actually can't make use of ModifyExpressionValue, because I need to redirect the call that hurts the entity, and not add an extra condition to determine whether to hurt it or not.

However, Aileron just needs to add some conditions, so it shouldn't redirect the hurt call and instead use ModifyExpressionValue to add its conditions to prevent the call in certain cases.