search

CulverLab / sparcd

https://wildcatresearch.arizona.edu/
GNU General Public License v3.0
4 stars 7 forks source link

Search 5K limit fix #41

Closed Chris-Schnaufer closed 3 years ago

Chris-Schnaufer commented 3 years ago

This builds off PR https://github.com/CulverLab/sparcd/pull/40.

Updates some dependencies for building to newer versions Closing query after all records have been fetched

julianpistorius commented 3 years ago

@Chris-Schnaufer is this PR ready to be merged?

Chris-Schnaufer commented 3 years ago

@Chris-Schnaufer is this PR ready to be merged?

Yes, both this and #40 are available for merging. This builds off PR 40, so you may want to merge that one first

julianpistorius commented 3 years ago

@Chris-Schnaufer it looks like #41 (this PR) has three commits ahead of the commits for #40, followed by some more commits. See the commits in the red rectangle below - the commits in the green rectangles are the ones they have in common:

PR 41 commits

mr-41-commits

PR 40 commits

mr-40-commits
julianpistorius commented 3 years ago

I am struggling to build and test the older version of the app now that I've upgraded it to Java 15, so I will test the upload retry behavior in #41 instead of in #40.

Chris-Schnaufer commented 3 years ago

I am struggling to build and test the older version of the app now that I've upgraded it to Java 15, so I will test the upload retry behavior in #41 instead of in #40.

Do you need anything from me?

julianpistorius commented 3 years ago

Do you need anything from me?

Nope. I got it working. Thanks!