search

CyberCraftInc / vacation_system

Cyber Craft Vacation System
0 stars 0 forks source link

Implement enhancement described in issue #27 #37

Closed eleidan closed 8 years ago

eleidan commented 8 years ago

Update App.Views.VacationRequestsList so that it is possible to cancel any vacation with status other than cancelled. Also, search filter is enabled. This functionality is provided by the plugin out of box. For details on search filter see http://bootstrap-table.wenzhixin.net.cn/documentation/#table-options

The search filter is supposed to replace previous filter mechanism implementation.

@alazarchuk , @epmlys , @rubycop , @afurm

afurm commented 8 years ago

Looks good now, thanks :+1:

I believe there are a lot of places where we still use statuses as hardcoded values, why we can't replace old statuses with a new model. What do you think? It could be separate PR if you want.

eleidan commented 8 years ago

I think it should be done in scope of the enhancement #38