search

CyberCraftInc / vacation_system

Cyber Craft Vacation System
0 stars 0 forks source link

Configure action mailer #96

Closed eleidan closed 8 years ago

rubycop commented 8 years ago

Do not forget add tests for mailer

eleidan commented 8 years ago

Does it make sense to test features from a potentially well tested gem? Consider that the default implementation is used, no custom implementations are provided in the application.

rubycop commented 8 years ago

You said about issues when app send email using yandex provider.

eleidan commented 8 years ago

I find it not feasible to test code I do not have access to, I mean code at Yandex. They can change theirs API any time they want. They can just close SMTP access etc. Again, I see no good reason to test vendor provided code, at least in this case.