CyberShadow / aconfmgr

A configuration manager for Arch Linux
1.19k stars 41 forks source link

Update dependency ShellCheck to v0.9.0 - autoclosed #158

Closed CyberShadow-Renovate closed 1 year ago

CyberShadow-Renovate commented 1 year ago

This PR contains the following updates:

Package Update Change
ShellCheck minor 0.8.0 -> 0.9.0

Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Enabled.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.



Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

CyberShadow commented 1 year ago

With -x -a -P src aconfmgr:


In src/common.bash line 1708:
    while str=$(caller $frame)
                           ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    while str=$(caller "$frame")

In src/helpers.bash line 350:
    file_content_filters[$pattern]=$function
                             ^------^ SC2004 (style): $/${} is unnecessary on arithmetic variables.

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2004 -- $/${} is unnecessary on arithmeti...

Both of these look like false positive regressions :(

CyberShadow commented 1 year ago

Upstream bugs filed:

CyberShadow commented 1 year ago

This got closed by accident as I was trying to update my Renovate fork. Continuation here: https://github.com/CyberShadow/aconfmgr/pull/177