CyberShadow / aconfmgr

A configuration manager for Arch Linux
1.13k stars 39 forks source link

PKGDEST modification prevents to update the configuration #199

Open Anarky opened 1 month ago

Anarky commented 1 month ago

General description of the problem:

If the PKGDEST variable is modified in the makepkg configuration, aconfmgr fails to find the first AUR package it compiles, preventing to update the configuration.

I found the offending line in common.bash#L1415, the directory path is hardcoded.

I can fix the issue and send a PR, but since 6.1.0 makepkg can have drop-ins inside /etc/makepkg.conf.d, it would mean to parse them too?

Steps to reproduce the problem:

  1. Edit /etc/makepkg.conf
  2. Change the PKGDEST variable e.g. /tmp/makepkg/_pkg
  3. Check the configuration $ aconfmgr save

Configuration:

No response

Expected result:

aconfmgr updates the configuration.

Actual result:

aconfmgr stops after the first compiled AUR package.

Log:

Unable to find package file for package foo!

Additional context:

No response

CyberShadow commented 1 month ago

Maybe makepkg provides a facility to dump its parsed configuration? Or, we can override this configuration value for builds done by aconfmgr?

makepkg support is really only there to bootstrap the user's preferred AUR helper.