D1firehail / AdeptiScanner-GI

OCR-based inventory scanner for Genshin Impact
50 stars 18 forks source link

Feature Requests. #14

Closed DChangka closed 10 months ago

DChangka commented 1 year ago

Hey!

I've been using your artifact scanning tool and am absolutely in love with it. It is a great replacement to the Amenoma tool (for which update operations have been kinda discontinued since 3.0).

Coming back to the topic at hand, I would like to put forth the following two feature requests that I feel would improve the convenience of this tool even further!

Many times while scanning through my artifact inventory, I would encounter a duplicate artifact (according to the scanner atleast. Although I do feel like it throws up that message even when there are no real duplicates.) that would immediately stop the scanning process.

My feature request here suggests the addition of an option that we can enable to allow the artifact scanner to continue scanning artifacts even if it does detect a duplicate. This, I feel will improve user convenience especially in situations where the artifact scan stops multiple times during an inventory scan due to detecting multiple duplicates along the way.

According to the current behavior of the application, the artifact scan alwats starts from the top of the visible page irrespective of where your in-game cursor is positioned. We can either make it an option or the new behavior of the application to start an artifact scan from the artifact that is selected by your in-game cursor.

And that's all I have to say here. I do hope that these feature requests get considered.

D1firehail commented 1 year ago

There are 4 reasons why it would detect a duplicate (that I'm aware of):

Ability to continue scanning despite detecting a "duplicate artifact"

No, for the following reasons

Start artifact scan from the artifact that is selected by your in-game cursor

This could be done by registering the initially selected artifact and not actually scanning any artifacts until we find the duplicate of this one. However, I don't really see the practical use of this, since Auto always finished the screen it's on. If you can present a good reason for wanting to do it, I'll consider it.