search

D1firehail / AdeptiScanner-GI

OCR-based inventory scanner for Genshin Impact
50 stars 18 forks source link

Fix typo in ArtifactInfo.json #19

Closed celeranis closed 7 months ago

celeranis commented 7 months ago

Fixes a typo in Alhaitham's name that broke my import from Enka

D1firehail commented 7 months ago

Thanks for the PR! There's some minor things that need fixing before I can accept it, though. If you don't, I can fix it myself in a few days.

  1. ArtifactInfo.json should not be modified directly, as it's minified for size at the cost of readability. The proper way to update it is to perform the change in ArtifactInfo_readable.json, then using a json minifier (for example https://codebeautify.org/jsonminifier ) to get the updated version of the non-readable one.

  2. The DataVersion tag also needs to be changed in some way, for example to 4.2b for the update checker to notice the change.

celeranis commented 7 months ago

I somehow completely overlooked the readable version the first time. It should be fixed now.