search

D3vl0per / Twitch-watcher

Automatic watching the twitch to get Valorant drop
MIT License
226 stars 66 forks source link

Customizable navigation timeout #19

Closed giovanni-orciuolo closed 4 years ago

giovanni-orciuolo commented 4 years ago

Sometimes I get a navigation timeout after 30 seconds from Puppeteer while navigating to the Twitch streamer page. It would be nice if I could customize this countdown from docker env directly, or a config of some sorts. I can make a PR about this if you wish

giovanni-orciuolo commented 4 years ago

Just made the PR 🌟

D3vl0per commented 4 years ago

Soory, i don’t understand. 😕

giovanni-orciuolo commented 4 years ago

I made a Pull Request to request you to merge my changes into your main repo. I added a navigation timeout

giovanni-orciuolo commented 4 years ago

21

D3vl0per commented 4 years ago

Good job! https://github.com/D3vl0per/Valorant-watcher/tree/2.0.1

giovanni-orciuolo commented 4 years ago

Could you update the docker image?

D3vl0per commented 4 years ago

I did it! Screenshot_20200418_001302

parentless commented 4 years ago

I have that version with the customizeable timeouts and that error is still happening for me?

realjesset commented 4 years ago

I have that version with the customizeable timeouts and that error is still happening for me?

likewise, I have tried to add timeouts and stuff yet it hasn't been solving the issue.