search

DCPUTeam / DCPUToolchain

[ARCHIVED] The code repository for the DCPU-16 Toolchain.
http://dcputoolcha.in/
MIT License
96 stars 14 forks source link

Bundling libraries is optional #202

Closed Ape closed 11 years ago

Ape commented 11 years ago

I understand that we want to keep the bundled libraries available as it makes lot easier especially on Windows. This patch doesn't affect the default behaviour at all or remove anything. It just adds a small, nonintrusive set of cmake options that allow using the system libraries instead of the bundled ones.

I just ask you to give me this, to make building and packaging a lot nicer for me. I don't say we should advertise those options to everybody. Also, this doesn't make us any requirements about supporting any specific library versions. I and distro packagers can use the versions that are bundled or any equivalent. Updating the bundled libraries is a separate case.

Thanks.

Ape commented 11 years ago

This is a follow-up on my previous, to be honest quite aggressive pull request [1]. I hope this is more acceptable. It gives me all the benefits I really wanted with the previous request, anyway.

[1] https://github.com/DCPUTeam/DCPUToolchain/pull/201

jdiez17 commented 11 years ago

:thumbsup:

Thanks!