DDMAL / CantusDB

A new site for Cantus Database running under Django.
https://cantusdatabase.org
MIT License
5 stars 6 forks source link

Melody Search js could be cleaned up #1133

Open dchiller opened 10 months ago

dchiller commented 10 months ago

In the course of completing #1130, some opportunities to clarify and simply the Javascript for the melody search tool were identified. In the interest of quickly fixing the bugs identified in #1128, these changes were not immediately implemented. I'm opening this issue to track these opportunities:

jacobdgm commented 10 months ago

Currently, it seems like the browser downloads the image for the "notehead" anew each time the mouse changes positions on the staff. This doesn't seem to be causing performance problems (the images are small), but there also may be a quick way to download all the images and show them when necessary

My initial instinct would be to use text/volpiano rather than images. Guessing that this was how it was set up in OldCantus, but is there any reason why we can't/shouldn't do it with text?

jacobdgm commented 10 months ago

Aside: it's interesting to inspect elements on https://cantus.uwaterloo.ca/melody - you come across things like https://cantus.uwaterloo.ca/sites/default/files/noty/searchmelody.js. You get functions like Zobrazit, and properties like CiselnaHodnota ("ciselna note head"?). I gather these must be descriptive variable names in Czech!

annamorphism commented 10 months ago

"numerical value", I think, though why the value would be a pitch/letter I am not sure...