Open annamorphism opened 7 months ago
dchiller
commented
7 months ago Ok, I see.
The syllabifier doesn't expect square brackets outside of an ipsum formulation. Obviously, we don't want the server error because then you can't fix it.
I've made https://github.com/DDMAL/volpiano-display-utilities/issues/48 to address this.
annamorphism
commented
2 months ago I thought this issue had been closed, but it seems aspects are still present. https://cantusdatabase.org/chant/1004954 gave a server error; the text entered looked like so:
annamorphism
commented
2 months ago aha! on closer inspection, the square brackets in the standard spelling field are fine, but there is a stray square bracket paired with a curly bracket in the source spelling field that is causing a 500 error.
dchiller
commented
4 days ago Just tested this again, and I think it is now handled with #1653. Having unpaired brackets of various types now does not lead to any server errors...texts and volpiano are shown, even if there is an error in alignment.
The only thing I might change is to get rid of the "Melody with Text" header when there is such an error. I will make that change and I think with that we can consider this closed.
A user wrote to me that she had used the wrong kind of brackets in one of her chants and got a server error, which meant she also couldn't go back and fix it after the fact, since she was getting an error.
I was able to look in the admin interface at the offending chant (1002931):
A little testing suggests the problem is the square brackets in the MS full text, which lead me to a 500 error on test chants. @dchiller any ideas? For now I will wait to correct the offending brackets, but tomorrow I will go ahead and fix them so our inventorier can get on with what she was doing.