search

DDMAL / CantusDB

A new site for Cantus Database running under Django.
https://cantusdatabase.org
MIT License
5 stars 6 forks source link

Update .gitignore #1518

Closed lucasmarchd01 closed 1 month ago

lucasmarchd01 commented 1 month ago

Adds config/nginx/conf.d/cantusdb.conf.development to .gitignore so we aren't tracking changes to this file. I found this while setting up my environment locally this week.

dchiller commented 1 month ago

I don't think we want to do this?

This file is already in the repo, and I think is how we track any changes needed in the cantusdb.conf for local development. See https://github.com/DDMAL/CantusDB/wiki/Deploying-CantusDB-locally-for-development#set-up.

lucasmarchd01 commented 1 month ago

Okay, that makes sense. git was still tracking cantusdb.conf.development as a file that has been deleted since it was renamed. I think then, instead, we should change the documentation from this:

Rename config/nginx/conf.d/cantusdb.conf.development to cantusdb.conf.

To this: Duplicate config/nginx/conf.d/cantusdb.conf.development and rename it to cantusdb.conf.

dchiller commented 1 month ago

Ah, yes. That documentation change makes sense (it was somehow what I did locally so I didn't noticed that the documentation was wrong :(

lucasmarchd01 commented 1 month ago

Yeah it wasn't an issue on my lab computer either so I guess I must have done the same thing! I'll go and update the page.