DDMAL / CantusDB

A new site for Cantus Database running under Django.
https://cantusdatabase.org
MIT License
5 stars 6 forks source link

Merge staging into production, 14 Aug 2024 #1601

Open lucasmarchd01 opened 1 month ago

lucasmarchd01 commented 1 month ago

To Test:

Commands to run on production: *** to add here

dchiller commented 1 month ago

Thanks @lucasmarchd01 ! I'll start testing.

lucasmarchd01 commented 1 month ago

Has the command to reassign feasts in #1564 already been run? I noticed they've already been reassigned and deleted before I ran the command.

Also, I'm just about to run #1580

dchiller commented 1 month ago

Has the command to reassign feasts in #1564 already been run? I noticed they've already been reassigned and deleted before I ran the command.

Hmm...I don't think I ran it. At least, I shouldn't have.

Also, I'm just about to run #1580

Nice! šŸ¤ž

dchiller commented 1 month ago

Has the command to reassign feasts in #1564 already been run? I noticed they've already been reassigned and deleted before I ran the command.

Wait it looks like you ran it: https://github.com/DDMAL/CantusDB/issues/1560#issuecomment-2269241101

šŸ˜‰

lucasmarchd01 commented 1 month ago

Wait it looks like you ran it: #1560 (comment)

šŸ˜‰

šŸ¤¦ā€ā™‚ļø

dchiller commented 1 month ago

Ok, because these changes do a bunch with the sources and institutions, I'm gonna email everyone to take a look too. For example, at this page: https://staging.cantusdatabase.org/sources/.

I know that Debra also wanted #1583, but that could come in a future release.

lucasmarchd01 commented 1 month ago

Ok, because these changes do a bunch with the sources and institutions, I'm gonna email everyone to take a look too. For example, at this page: https://staging.cantusdatabase.org/sources/.

Good idea!

I know that Debra also wanted https://github.com/DDMAL/CantusDB/issues/1583, but that could come in a future release.

We can also try and quickly push this feature to staging. I assumed we'd have to do another merge of develop into staging before the release anyways.

dchiller commented 1 month ago

@lucasmarchd01 I am getting a 404 on flatpages on staging...are you?

lucasmarchd01 commented 1 month ago

@lucasmarchd01 I am getting a 404 on flatpages on staging...are you?

Interesting... I can access the flatpages when I'm logged out, but once I log in I'm getting the 404.

dchiller commented 1 month ago

Interesting... I can access the flatpages when I'm logged out, but once I log in I'm getting the 404.

Ah ok, I didn't realize it but that's exactly what's happening with me too.

Update: also doesn't happen to me on develop locally.

Update 2: I just found #1608 on staging, but I'm not sure that that would be relevant to this problem.

Update 3: I believe this has been solved. See #1610.

lucasmarchd01 commented 1 week ago

Are we ready to merge into production?