DDMAL / CantusDB

A new site for Cantus Database running under Django.
https://cantusdatabase.org
MIT License
5 stars 6 forks source link

Adjust source fields: holding_institution, name, production_method, source_completeness #1645

Open dchiller opened 3 days ago

dchiller commented 3 days ago

NOTE: This PR removes some previously-committed migrations. You will need to re-create your local/staging database to do development after this PR is merged. I decided to do this because it will make the update of production go smoother (ie. not have to run to a certain migration, then run the migrate_records command, then apply the rest of the migrations), which ultimately felt preferable to prioritizing people's individual current development database status.

Makes significant changes to the Source model:

These changes are reflected in source create, edit, detail, and list pages. Relevant tests are also updated.

Makes cosmetic changes to the Institution model by changing various field defaults from latin abbreviations to english words.

Adds the source's name field to source create, edit, and detail views and to the source heading.

Performs some minor cosmetic changes: refactors forms.py a bit with a new StyledChoiceField class so that repeated changes to widget style attributes are no longer necessary and changes the ordering of the options in the "Holding Institution" input field on the Source admin page.

To-Do's

Closes #1628.

dchiller commented 3 days ago

The failing test will be fixed with the merge of #1643 -- once that is reviewed and merged I'll fix this.

dchiller commented 2 days ago

Tests are now passing. Have not heard back confirmation on some of the remaining formatting questions, so holding for the moment.