DDMAL / CantusDB

A new site for Cantus Database running under Django.
https://cantusdatabase.org
MIT License
5 stars 6 forks source link

Feast Detail Page: why are we displaying so many frequent chants? #596

Closed jacobdgm closed 3 months ago

jacobdgm commented 1 year ago

On this Feast Detail page, we're currently displaying all the chants associated with the feast. OldCantus only shows 50 chants. The same is true for the "Sources containing this feast" list. We should change the behavior of NewCantus to match OldCantus.

Considerations:

jacobdgm commented 1 year ago

assigning @lucasmarchd01 because you've recently handled multiple paginations.

I don't think this is important enough to prevent us from launching NewCantus (either "soft" or "full"), and I feel the "low priority" label is still justified, but we should fix this eventually.

lucasmarchd01 commented 1 year ago

After implementing pagination on the feast-detail page, I realized that this wouldn't actually solve the loading time issues for this page. This is because we fetch information for all of the cantus_ids in the feast (count, incipit, genre) and zip them to be used in the template. Pagination would not solve the issue since we still need to fetch this information before paginating. It might be worth considering setting up a model for cantus_id so that we can optimize the number of queries on this page and likely on other pages as well.