DDMAL / CantusDB

A new site for Cantus Database running under Django.
https://cantusdatabase.org
MIT License
5 stars 6 forks source link

Cantus ID field should not allow leading/trailing whitespace #986

Open JoyfulGen opened 1 year ago

JoyfulGen commented 1 year ago

For example, this is a search where the only thing I specified was "V2" in the Office/Mass dropdown menu. Then I clicked on Cantus ID to order the list from smallest Cantus ID to largest. The result is this:

Chant search IDs order

You can see that the first six IDs aren't ordered, and I can't tell why. When the list gets to 000000, then the order begins correctly and everything after that seems fine.

The same thing happens with other searches I've tried; the first few Cantus IDs don't seem to be ordered, and then the order picks up correctly. Other examples:

Search for "S" office/mass - Only first result not in order Search for "A" genre - First 21 results not in order Search for "octava" in Feast - First 3 results not in order

@annamorphism, do you know why this is?

annamorphism commented 1 year ago

The first couple chants in that list have a leading space in the Cantus ID, which, incidentally, leads to a broken URL: https://cantusindex.org/id/ 008169 . This is a bit of data-entry error visible if you try to edit the chant in question: https://cantusdatabase.org/chant/667054

image

Poking around OldCantus it seems to always have been the case (it's not anything we did), but as there aren't that many chants with this issue and not all of these searches were possible on OldCantus I don't think anybody found them! I'm assuming we could just delete leading spaces in CantusIDs and fix this?

annamorphism commented 1 year ago

Actually that's not quite all of it--in the first couple results of the "A" search there are some that are not a leading space, but some sort of leading tab, like so (https://cantusdatabase.org/edit-chants/123631?pk=620289&folio=013r&ref=chant-detail)

image

Considering there are 210660 results for "A" I think 21 with a data entry problem is not bad! But we should be able to filter them out.

jacobdgm commented 1 year ago

It sounds like @annamorphism has identified the problem. Renaming this issue to reflect the underlying issue.

What we should probably do is: